Set the operator up with enforced secrets #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr1128/skitt/enforce-mountable-secrets |
3d0bcac to
728d7bc
Compare
dfarrell07
approved these changes
May 16, 2024
To prevent arbitrary secret access using compromised SAs, the SAs created by Submariner are now configured to enforce mountable secrets. This requires that accessible secrets be listed explicitly in the SA. To make this simple, use a static name for the broker secret. To allow secrets to be configured, leave them alone when creating or updating the SAs. Signed-off-by: Stephen Kitt <skitt@redhat.com>
728d7bc to
e84b007
Compare
|
This PR/issue depends on: |
aswinsuryan
approved these changes
May 16, 2024
tpantelis
approved these changes
May 16, 2024
|
🤖 Closed branches: [z_pr1128/skitt/enforce-mountable-secrets] |
|
We were hoping to see this work in 0.18, including d/s, before backporting it. |
tpantelis
added a commit
to skitt/subctl
that referenced
this pull request
Jul 9, 2024
…1128-origin-release-0.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent arbitrary secret access using compromised SAs, the SAs created by Submariner are now configured to enforce mountable secrets. This requires that accessible secrets be listed explicitly in the SA. To make this simple, use a static name for the broker secret. To allow secrets to be configured, leave them alone when creating or updating the SAs.
Depends on submariner-io/submariner-operator#3064
Depends on submariner-io/submariner-operator#3067