[WIP] Removing turbomachinery legacy output #2001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: SU2_CFD/include/solvers/CEulerSolver.hpp SU2_CFD/src/integration_time.cpp SU2_CFD/src/iteration_structure.cpp SU2_CFD/src/meson.build SU2_CFD/src/solvers/CEulerSolver.cpp SU2_CFD/src/solvers/CNSSolver.cpp
…e screen output iterations
…://github.com/su2code/SU2 into feature_turbomachinery_restruct_singlezone
…ery boundary value table added for priting, printing frequency is still hard coded, to be fixed in future
…ing Plane under process. Turbine and Compressor calcualtion if statement added
…e performance is not computer for all blades. This needs to be identified and implemented
…ixed and turbo span calculation to be fixed.
…. Mutizone is still crashing... investigation in progress
…shkellyjak/SU2_turbo_legacy_output into feature_turbomachinery_output
remerge develop to include turbo performance features previously implemented in restruct singlezone
…shkellyjak/SU2_turbo_legacy_output into feature_turbomachinery_output
|
Maybe we can chat in the developer meeting today at 4pm CET (in 2.5h) https://meet.jit.si/SU2_DevMeeting it looks like this is becoming harder than it needs to 😅 |
|
Sounds good, see you then |
|
see #2003 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Transferring turbomachinery outputs from legacy format to current format
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.