Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Removing turbomachinery legacy output #2001

Closed
wants to merge 77 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
6947268
restruct single-zone turbo problem to run without TurboDriver and Tur…
Feb 8, 2020
854295c
isolate turboperformance
Mar 11, 2020
305dec9
Merge branch 'develop' into feature_turbomachinery_restruct_singlezone
salvovitale Mar 11, 2020
fd32865
change some loops
Mar 11, 2020
6ebd4d9
Branch updated with Develop, Turbo-performance parameters added in th…
NAnand-TUD Mar 1, 2021
2bd3dc7
Brnach updated with develop
NAnand-TUD Mar 1, 2021
a5ec64f
History writing is working... Turbomachinery performance calculation …
NAnand-TUD Mar 3, 2021
0a4c691
implement some of Pedro comments
Mar 4, 2021
d929b93
fix issue with InletState not available in Output
Mar 5, 2021
7f36374
Testing output
NAnand-TUD Mar 5, 2021
7a60aef
:q!Merge branch 'feature_turbomachinery_restruct_singlezone' of https…
NAnand-TUD Mar 5, 2021
90b1114
History tabled fixed with mass flow convergence vales and turbomachin…
NAnand-TUD Mar 5, 2021
121dd26
Single zone and Multizone implemented... Debugging multizone with Mix…
NAnand-TUD Mar 8, 2021
7a8d088
Mixing Plane is working
NAnand-TUD Mar 11, 2021
b3b9143
Mass flow and performance calculations fixed
NAnand-TUD Mar 11, 2021
0da413c
Testing Mass Flow rate for 3D problems
NAnand-TUD Mar 11, 2021
a4e75cc
Mutizone display being fixed now
NAnand-TUD Mar 15, 2021
92cb7f3
Stil exploring the performance calculatings, Currently, seems like th…
NAnand-TUD Mar 15, 2021
45010b9
Mixing Plane call is now fixed, but there is still segmentation fault
NAnand-TUD Mar 17, 2021
174a8fb
Mixing-Plane possible is now working.. validation in progress
NAnand-TUD Mar 17, 2021
aa6defd
Performance priting is fixed now
NAnand-TUD Mar 19, 2021
607678b
Single zone was crashing... It is fixed now
NAnand-TUD Mar 19, 2021
549a4fa
Logical error fixed
NAnand-TUD Mar 22, 2021
73cf81d
2D MultiZone Turbomachinery test case is working, performance to be f…
NAnand-TUD Apr 6, 2021
b4eb8a5
Span Calculation fixed and multizone mixing plane fixed
NAnand-TUD Apr 7, 2021
8783fee
Commented turbo performance to check a code in HPC
NAnand-TUD Apr 9, 2021
16b84fd
Back Pressure and Rotation Ramp implemented, Testing in progress
NAnand-TUD Apr 11, 2021
e6cf5f9
Multi-Zone grid rotation and backpressure ramp is now working
NAnand-TUD Apr 12, 2021
2c9f80b
Small error in Mutizone output: Now fixed
NAnand-TUD Apr 13, 2021
858b283
Single zone performance computaion is working with revised approach..…
NAnand-TUD Apr 22, 2021
1601002
Latest Changes
NAnand-TUD May 7, 2021
bd0fb25
small changes
NAnand-TUD May 7, 2021
3b2552f
Small errors
NAnand-TUD May 7, 2021
cda5861
Mutizone again establized, machine performance under process
NAnand-TUD Jun 14, 2021
997cabd
Mutizone again establized, machine performance under process
NAnand-TUD Jun 14, 2021
1ef9960
Performance computation per blade is working, for 2D MZ problems, 3D …
NAnand-TUD Jun 16, 2021
c25a721
MZ performance compuation is working now, also span wise calcualtion …
NAnand-TUD Jun 18, 2021
64cf875
Performance calculations added: Some testing in progress
NAnand-TUD Jun 22, 2021
6d29126
Merged with Develop, some code cleaning in progress
NAnand-TUD Jun 23, 2021
1888aa5
Fixes in performacne output
NAnand-TUD Jul 1, 2021
b5679b2
Changes made to comply with the comments
NAnand-TUD Jul 12, 2021
724b77c
Small bug fix and performance improvement
NAnand-TUD Aug 9, 2021
a5a503e
Boost capability removed, Adjoint is compiling now
NAnand-TUD Oct 1, 2021
c002a72
added MASS_FLOW_OUTLET BC, fixed turbo performance
andrea-giuffre Apr 4, 2022
a151f7d
added Enthalpy, Tot Enthalpy and Sound Speed in volume output fields
andrea-giuffre Apr 16, 2022
fc6790e
Adding CTurbomachineryOutput
Tushma Apr 3, 2023
b4bbc5c
Removed output_physics.cpp
Tushma Apr 3, 2023
b8eee87
Removed output_physics
Tushma Apr 3, 2023
c36eeff
Quick fixes
Tushma Apr 4, 2023
c83dcdf
fixes
Tushma Apr 4, 2023
9a21e02
more build fixes
Tushma Apr 4, 2023
8e840e5
move TurbomachineryOuput to FlowOutput
Tushma Apr 4, 2023
48b323c
Moving TurboOuput to FlowOutput
Tushma Apr 4, 2023
c44bf8b
More turbo outputs
Tushma Apr 4, 2023
541229d
merge restruc_singlezone into remove_leagcy_output
Tushma Apr 4, 2023
80c30fa
small fixes
Tushma Apr 4, 2023
dd85aef
small fixes
Tushma Apr 4, 2023
e476485
more fixes
Tushma Apr 4, 2023
e4593c8
fixes
Tushma Apr 4, 2023
56dc0e5
more fixes
Tushma Apr 4, 2023
5c583e7
comma
Tushma Apr 4, 2023
ee70d9f
.cpp
Tushma Apr 4, 2023
44dcb8d
some changes
Tushma Apr 4, 2023
fa581f8
tests
Tushma Apr 4, 2023
ff8e859
fixes
Tushma Apr 4, 2023
741d8d7
I HAVE NO IDEA WHAT I AM DOING
Tushma Apr 4, 2023
56ce2dd
fixes
Tushma Apr 5, 2023
d255c36
Merge branch 'feature_turbomachinery_output' of https://github.com/jo…
Tushma Apr 5, 2023
b8ff357
testing removing ComputeTurboPerformance
Tushma Apr 5, 2023
0e67400
discadj modification
Tushma Apr 5, 2023
85adc08
commenting
Tushma Apr 5, 2023
7cefd35
Merge remote-tracking branch 'origin/develop' into feature_turbomachi…
Tushma Apr 5, 2023
b09992f
Remerge develop
Tushma Apr 5, 2023
31524a5
Merge branch 'feature_turbomachinery_output' of https://github.com/jo…
Tushma Apr 5, 2023
2387941
typo
Tushma Apr 5, 2023
3caddac
test
Tushma Apr 5, 2023
f2d180c
test
Tushma Apr 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Common/include/CConfig.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ class CConfig {
unsigned short Kind_PerformanceAverageProcess; /*!< \brief Kind of mixing process.*/
unsigned short Kind_MixingPlaneInterface; /*!< \brief Kind of mixing process.*/
unsigned short Kind_SpanWise; /*!< \brief Kind of span-wise section computation.*/
unsigned short *Kind_TurboMachinery; /*!< \brief Kind of turbomachynery architecture.*/
unsigned short iZone, nZone; /*!< \brief Number of zones in the mesh. */
unsigned short nZoneSpecified; /*!< \brief Number of zones that are specified in config file. */
su2double Highlite_Area; /*!< \brief Highlite area. */
Expand Down Expand Up @@ -433,6 +432,9 @@ class CConfig {
CFLFineGrid, /*!< \brief CFL of the finest grid. */
Max_DeltaTime, /*!< \brief Max delta time. */
Unst_CFL; /*!< \brief Unsteady CFL number. */

TURBO_PERF_KIND *Kind_TurboPerf; /*!< \brief Kind of turbomachynery architecture.*/
TURBOMACHINERY_TYPE *Kind_TurboMachinery;

/* Gradient smoothing options */
su2double SmoothingEps1; /*!< \brief Parameter for the identity part in gradient smoothing. */
Expand Down Expand Up @@ -5037,7 +5039,7 @@ class CConfig {
* \brief Get the kind of turbomachinery architecture.
* \return Kind of turbomachinery architecture.
*/
unsigned short GetKind_TurboMachinery(unsigned short val_iZone) const { return Kind_TurboMachinery[val_iZone]; }
TURBOMACHINERY_TYPE GetKind_TurboMachinery(unsigned short val_iZone) const { return Kind_TurboMachinery[val_iZone]; }

/*!
* \brief Get the kind of turbomachinery architecture.
Expand Down Expand Up @@ -5174,10 +5176,10 @@ class CConfig {
string GetMarker_TurboPerf_BoundOut(unsigned short index) const { return Marker_TurboBoundOut[index];}

/*!
* \brief get marker kind for Turbomachinery performance calculation.
* \brief get marker kind for Turbomachinery performance calculation kind.
* \return kind index.
*/
unsigned short GetKind_TurboPerf(unsigned short index);
TURBO_PERF_KIND GetKind_TurboPerf(unsigned short val_iZone) const { return Kind_TurboPerf[val_iZone]; };

/*!
* \brief get outlet bounds name for Turbomachinery performance calculation.
Expand Down
41 changes: 29 additions & 12 deletions Common/include/option_structure.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1649,7 +1649,8 @@ enum RIEMANN_TYPE {
TOTAL_CONDITIONS_PT_1D = 11,
STATIC_PRESSURE_1D = 12,
MIXING_IN_1D = 13,
MIXING_OUT_1D =14
MIXING_OUT_1D = 14,
MASS_FLOW_OUTLET = 15 /*!< \brief User prescribes the mass flow rate at the outlet boundary */
};
static const MapType<std::string, RIEMANN_TYPE> Riemann_Map = {
MakePair("TOTAL_CONDITIONS_PT", TOTAL_CONDITIONS_PT)
Expand All @@ -1666,6 +1667,7 @@ static const MapType<std::string, RIEMANN_TYPE> Riemann_Map = {
MakePair("RADIAL_EQUILIBRIUM", RADIAL_EQUILIBRIUM)
MakePair("TOTAL_CONDITIONS_PT_1D", TOTAL_CONDITIONS_PT_1D)
MakePair("STATIC_PRESSURE_1D", STATIC_PRESSURE_1D)
MakePair("MASS_FLOW_OUTLET", MASS_FLOW_OUTLET)
};

static const MapType<std::string, RIEMANN_TYPE> Giles_Map = {
Expand All @@ -1683,6 +1685,7 @@ static const MapType<std::string, RIEMANN_TYPE> Giles_Map = {
MakePair("RADIAL_EQUILIBRIUM", RADIAL_EQUILIBRIUM)
MakePair("TOTAL_CONDITIONS_PT_1D", TOTAL_CONDITIONS_PT_1D)
MakePair("STATIC_PRESSURE_1D", STATIC_PRESSURE_1D)
MakePair("MASS_FLOW_OUTLET", MASS_FLOW_OUTLET)
};

/*!
Expand Down Expand Up @@ -1730,19 +1733,33 @@ static const MapType<std::string, SPANWISE_TYPE> SpanWise_Map = {
/*!
* \brief Types of mixing process for averaging quantities at the boundaries.
*/
enum TURBOMACHINERY_TYPE {
AXIAL = 1, /*!< \brief axial turbomachinery. */
CENTRIFUGAL = 2, /*!< \brief centrifugal turbomachinery. */
CENTRIPETAL = 3, /*!< \brief centripetal turbomachinery. */
CENTRIPETAL_AXIAL = 4, /*!< \brief mixed flow turbine. */
AXIAL_CENTRIFUGAL = 5 /*!< \brief mixed flow turbine. */
enum class TURBOMACHINERY_TYPE {
AXIAL, /*!< \brief axial turbomachinery. */
CENTRIFUGAL, /*!< \brief centrifugal turbomachinery. */
CENTRIPETAL, /*!< \brief centripetal turbomachinery. */
CENTRIPETAL_AXIAL, /*!< \brief mixed flow turbine. */
AXIAL_CENTRIFUGAL, /*!< \brief mixed flow turbine. */
};
static const MapType<std::string, TURBOMACHINERY_TYPE> TurboMachinery_Map = {
MakePair("AXIAL", AXIAL)
MakePair("CENTRIFUGAL", CENTRIFUGAL)
MakePair("CENTRIPETAL", CENTRIPETAL)
MakePair("CENTRIPETAL_AXIAL", CENTRIPETAL_AXIAL)
MakePair("AXIAL_CENTRIFUGAL", AXIAL_CENTRIFUGAL)
MakePair("AXIAL", TURBOMACHINERY_TYPE::AXIAL)
MakePair("CENTRIFUGAL", TURBOMACHINERY_TYPE::CENTRIFUGAL)
MakePair("CENTRIPETAL", TURBOMACHINERY_TYPE::CENTRIPETAL)
MakePair("CENTRIPETAL_AXIAL", TURBOMACHINERY_TYPE::CENTRIPETAL_AXIAL)
MakePair("AXIAL_CENTRIFUGAL", TURBOMACHINERY_TYPE::AXIAL_CENTRIFUGAL)
};

/*!
* \brief Types of Turbomachinery performance Type.
*/
enum class TURBO_PERF_KIND{
TURBINE, /*!< \brief Turbine Performance. */
COMPRESSOR, /*!< \brief Compressor Performance. */
PROPELLOR /*!< \brief Propellor Performance. */
};
static const MapType<std::string, TURBO_PERF_KIND> TurboPerfKind_Map = {
MakePair("TURBINE", TURBO_PERF_KIND::TURBINE)
MakePair("COMPRESSOR", TURBO_PERF_KIND::COMPRESSOR)
MakePair("PROPELLOR", TURBO_PERF_KIND::PROPELLOR)
};

/*!
Expand Down
3 changes: 3 additions & 0 deletions Common/src/CConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,9 @@ void CConfig::SetConfig_Options() {
/*!\brief TURBOMACHINERY_KIND \n DESCRIPTION: types of turbomachynery architecture.
\n OPTIONS: see \link TurboMachinery_Map \endlink \n Default: AXIAL */
addEnumListOption("TURBOMACHINERY_KIND",nTurboMachineryKind, Kind_TurboMachinery, TurboMachinery_Map);
/*!\brief TURBOMACHINERY_KIND \n DESCRIPTION: types of turbomachynery Performance Calculations.
\n OPTIONS: see \link TurboPerfKind_Map \endlink \n Default: TURBINE */
addEnumListOption("TURBO_PERF_KIND", nTurboMachineryKind, Kind_TurboPerf, TurboPerfKind_Map);
/*!\brief MARKER_SHROUD \n DESCRIPTION: markers in which velocity is forced to 0.0 .
* \n Format: (shroud1, shroud2, ...)*/
addStringListOption("MARKER_SHROUD", nMarker_Shroud, Marker_Shroud);
Expand Down
Loading