Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the legacy output classes #2003

Merged
merged 9 commits into from
Apr 14, 2023
Merged

Remove the legacy output classes #2003

merged 9 commits into from
Apr 14, 2023

Conversation

pcarruscag
Copy link
Member

Proposed Changes

Remove the legacy output and run turbomachinery cases with the single and multizone drivers.
The special turbomachinery outputs have been lost in the process but folks in the Turbo group are working on re-introducing them under the "new" (3 years old already 😄) output classes.

The harmonic balance driver loses very little, it only had one small special output file in the legacy output, we do not have one output per time instance and so the output from all instances is shown on screen and piped to the same history file.
I'm leaving it like this hoping that the vacuum sucks in some new development into HB in SU2.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pcarruscag pcarruscag force-pushed the remove_legacy_output branch from fc34fdf to 22b45b7 Compare April 6, 2023 15:58
@joshkellyjak joshkellyjak mentioned this pull request Apr 14, 2023
6 tasks
@pcarruscag pcarruscag merged commit c7b6dbf into develop Apr 14, 2023
@pcarruscag pcarruscag deleted the remove_legacy_output branch April 14, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants