Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Enable Prometheus scraping #380

Closed
wants to merge 4 commits into from
Closed

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 3, 2022

Description

Fixes #379

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from a team February 3, 2022 10:29
@nightkr nightkr self-assigned this Feb 3, 2022
@lfrancke
Copy link
Member

lfrancke commented Feb 3, 2022

I know it is boring but could you add a section to the docs for this?
I don't think it needs to be a whole book about monitoring, maybe just a monitoring document for now that mentions that all pods that are created have this label and are prometheus "enabled"?

@nightkr
Copy link
Member Author

nightkr commented Feb 3, 2022

@lfrancke I created stackabletech/documentation#132 for the docs since this is more of a platform-wide concern. Do you want this to be documented in each individual operator as well?

@lfrancke
Copy link
Member

lfrancke commented Feb 3, 2022

I'm torn....let's say someone looks at the ZK Operator docs I think it'd be good to at least have a link to the platform-wide monitoring docs.

@nightkr
Copy link
Member Author

nightkr commented Feb 3, 2022

Does Antora have a fancy way to link between products in the same playbook, or should I just use the full URL?

@nightkr
Copy link
Member Author

nightkr commented Feb 3, 2022

Ok, figured out how to do it and added a note both here and in stackabletech/kafka-operator#308.

@nightkr
Copy link
Member Author

nightkr commented Feb 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 4, 2022
@bors
Copy link
Contributor

bors bot commented Feb 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable Prometheus scraping [Merged by Bors] - Enable Prometheus scraping Feb 4, 2022
@bors bors bot closed this Feb 4, 2022
@bors bors bot deleted the feature/prom branch February 4, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Prometheus scraping
2 participants