Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Enable Prometheus scraping #308

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Enable Prometheus scraping #308

wants to merge 6 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 3, 2022

Description

Fixes #307

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from a team February 3, 2022 10:31
@nightkr nightkr self-assigned this Feb 3, 2022
@nightkr
Copy link
Member Author

nightkr commented Feb 3, 2022

Hm, looks like the metrics endpoint exposed is actually børked, moving this to in progress for now.

@nightkr
Copy link
Member Author

nightkr commented Feb 3, 2022

Fixed.

@nightkr nightkr mentioned this pull request Feb 3, 2022
Closed
6 tasks
@nightkr nightkr mentioned this pull request Feb 4, 2022
Closed
6 tasks
razvan
razvan approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nightkr
Copy link
Member Author

nightkr commented Feb 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 4, 2022
@nightkr
Enable Prometheus scraping (#308)
a82a057 
## Description

Fixes #307
@bors
Copy link
Contributor

bors bot commented Feb 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable Prometheus scraping [Merged by Bors] - Enable Prometheus scraping Feb 4, 2022
@bors bors bot closed this Feb 4, 2022
@bors bors bot deleted the feature/prom branch February 4, 2022 11:24
@lfrancke
Copy link
Member

lfrancke commented Feb 4, 2022

Nooo! There is atypo in here. It says ZooKeeper

@nightkr
Copy link
Member Author

nightkr commented Feb 4, 2022

Oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@nightkr nightkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Prometheus scraping
3 participants
@nightkr @lfrancke @razvan