Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Enable Prometheus scraping #380

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.

### Added

- Enabled Prometheus scraping ([#380]).
- ZookeeperZnode.spec.clusterRef.namespace now defaults to .metadata.namespace ([#382]).

### Changed
Expand All @@ -17,6 +18,7 @@ All notable changes to this project will be documented in this file.
[#338]: https://github.com/stackabletech/zookeeper-operator/pull/338
[#340]: https://github.com/stackabletech/zookeeper-operator/pull/340
[#352]: https://github.com/stackabletech/zookeeper-operator/pull/352
[#380]: https://github.com/stackabletech/zookeeper-operator/pull/380
[#382]: https://github.com/stackabletech/zookeeper-operator/pull/382

## [0.8.0] - 2021-12-22
Expand Down
4 changes: 4 additions & 0 deletions docs/modules/ROOT/pages/usage.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,7 @@ Finally, a ConfigMap is created, containing a path that a ZooKeeper client can c
$ kubectl get configmap simple-znode-nodeport -o yaml
$ $ZOOKEEPER_HOME/bin/zkCli.sh -server $(kubectl get configmap simple-znode-nodeport -o jsonpath='{.data.ZOOKEEPER}')

== Monitoring

The managed ZooKeeper instances are automatically configured to export Prometheus metrics. See
xref:home::monitoring.adoc[] for more details.
1 change: 1 addition & 0 deletions rust/operator-binary/src/zk_controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ fn build_server_rolegroup_service(
&rolegroup.role,
&rolegroup.role_group,
)
.with_label("prometheus.io/scrape", "true")
.build(),
spec: Some(ServiceSpec {
cluster_ip: Some("None".to_string()),
Expand Down