Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCSt version to message header #1354

Closed
sabbyanandan opened this issue Apr 9, 2018 · 0 comments
Closed

Add SCSt version to message header #1354

sabbyanandan opened this issue Apr 9, 2018 · 0 comments
Assignees
@olegz
Labels
enhancement
Milestone
2.1.0.M1

Comments

@sabbyanandan
Copy link
Contributor

As a MetricsCollector developer, I'd like to receive a identifier representing SCSt version in the message header, so I can use it to identify 2.0 messages for downstream processing.

The goal for Metrics Collector via: spring-attic/spring-cloud-dataflow-metrics-collector#55 is to add support for both 1.x and 2.x messages single-handedly and to produce "streaming pipeline" representation of metrics for SCDF consistently.

Acceptance:

  • SCSt version included in the message-header
  • The release version is included regardless of the binder implementation in use
  • Test harness validates for version inclusion in the header
@olegz olegz self-assigned this Apr 9, 2018
@olegz olegz added this to the 2.1.x milestone Apr 9, 2018
@olegz olegz modified the milestones: 2.1.x, 2.1.0.M1 Apr 10, 2018
@olegz olegz added the 2.0.1 label Apr 10, 2018
olegz added a commit to olegz/spring-cloud-stream that referenced this issue Apr 11, 2018
@olegz
spring-cloudGH-1354 Added version header to Metric Message
3239bd1
olegz added a commit to olegz/spring-cloud-stream that referenced this issue Apr 11, 2018
@olegz
spring-cloudGH-1354 Added version header to Metric Message
aaab7d8 
Resolves spring-cloud#1354
Resolves spring-cloud#1356
@olegz olegz closed this as completed in 92f6d45 Apr 13, 2018
olegz added a commit that referenced this issue Apr 13, 2018
@olegz
GH-1354 Added version header to Metric Message
d355a2c 
Resolves #1354
Resolves #1356

polishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olegz olegz

Labels
enhancement
Projects
None yet
Milestone
2.1.0.M1
Development

No branches or pull requests
2 participants
@olegz @sabbyanandan