Skip to content
This repository was archived by the owner on Jul 9, 2022. It is now read-only.

Make Metrics Collector SCSt 1.0 and 2.0 compatible #55

Closed
sabbyanandan opened this issue Apr 9, 2018 · 0 comments
Closed

Make Metrics Collector SCSt 1.0 and 2.0 compatible #55

sabbyanandan opened this issue Apr 9, 2018 · 0 comments
Assignees
@tzolov
Milestone
2.0.0.M1

Comments

@sabbyanandan
Copy link

As a developer, I'd like to refactor 2.0 MC to be compatible to accept both SCSt 1.0 and 2.0 metrics. In other words, the same server can handle multiple versions of SCSt metrics.

This builds upon #51

Acceptance:

  • Detect and handle 1.0 vs. 2.0 SCSt payloads before Jackson conversion
  • Split 1.0 and 2.0 MC implementations into two separate packages (easy to deprecate older implementation at package level eventually)
  • Reuse common code as much as possible
  • Introduce test harness to test against mixed payload versions
  • Document caveats and the changes to SCDF if any
@sabbyanandan sabbyanandan added this to the 2.0.0.M1 milestone Apr 9, 2018
@sabbyanandan sabbyanandan mentioned this issue Apr 9, 2018
Closed
tzolov added a commit to tzolov/spring-cloud-dataflow-metrics-collector that referenced this issue Apr 11, 2018
@tzolov
Add SCSt 2.0 and Micrometer compatibility
3762a2e 
Resolve spring-attic#51
Resolve spring-attic#55

- Extend MetricAggregator to accept and dispatch Metrics coming from SpringBoot 1.x apps as well as MicrometerMetrics from SpringBoot2/SCSt2 apps.
  - Uses the spring.integration.send string as metrics type discriminator.
- MetricAggregator converts on the fly the received MicrometerMetrics classes into Metrics such.
  - The MicrometerMetrics multidimensional (e.g. multi-tag) identity is converted into hierarchical Metrics name convention.
  - Only the spring.integration.x MicrometerMetrics metrics are filtered in.
- The MicrometerMetrics have the rates precomputed. Therefore the ApplicationMetricsService rate computation logic is applied only to the Metrics (1.x) metrics.
- New compute logic for the Application#getAggregateMetrics
- Support for mixed SCSt1.x and SCSt2.x app metrics
- Fix the Metrics 1.x tests and add MicrometerMetric tests
@tzolov tzolov mentioned this issue Apr 11, 2018
Closed
@tzolov tzolov added in pr and removed in progress labels Apr 11, 2018
@markpollack markpollack removed the in pr label Apr 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tzolov tzolov

Labels
None yet
Milestone
2.0.0.M1
Development

No branches or pull requests
3 participants
@markpollack @tzolov @sabbyanandan