Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1354 Added version header to Metric Message #1356

Closed
wants to merge 1 commit into from

Conversation

olegz
Copy link
Contributor

@olegz olegz commented Apr 11, 2018

No description provided.

Copy link
Contributor

@sabbyanandan sabbyanandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! This should be enough for the Collector.

@tzolov: Do you have any other thoughts or improvements to this?

@codecov-io
Copy link

Codecov Report

Merging #1356 into master will decrease coverage by 0.44%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1356      +/-   ##
============================================
- Coverage     61.68%   61.23%   -0.45%     
+ Complexity      825      820       -5     
============================================
  Files           136      136              
  Lines          3933     3934       +1     
  Branches        550      550              
============================================
- Hits           2426     2409      -17     
- Misses         1229     1251      +22     
+ Partials        278      274       -4
Impacted Files Coverage Δ Complexity Δ
...ter/DefaultDestinationPublishingMeterRegistry.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...gframework/cloud/stream/binder/DefaultBinding.java 26.66% <0%> (-6.67%) 4% <0%> (-3%)
...ud/stream/binder/AbstractMessageChannelBinder.java 42.66% <0%> (-4.78%) 22% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa2581...aaab7d8. Read the comment docs.

@olegz
Copy link
Contributor Author

olegz commented Apr 12, 2018

Had a quick discussion with @tzolov and given that SCDF has the higher level concept of a Stream (implemented by SCSt) will change the header name to STREAM_CLOUD_STREAM_VERSION to be more explicit and clear as to what version is represented by this header.

@olegz olegz closed this in 92f6d45 Apr 13, 2018
olegz added a commit that referenced this pull request Apr 13, 2018
@olegz olegz deleted the GH-1354 branch December 27, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants