-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow *.xml (beside *.log) files as sample input files #550
Conversation
This PR is to address #549 |
I think it is a good one, @nandinivij WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this line
pytest-splunk-addon/pytest_splunk_addon/standard_lib/event_ingestors/requirement_event_ingester.py
Line 111 in 23deab5
if filename.endswith(".log"): |
And I would like to see a docker-based test that confirms that this feature works.
@arys-splunk , |
@hsekowski-splunk Can you please also change the target branch to develop? |
We will need changes unit test side too. Currently, we generate errors for anything other than .log and do not run prerequisite tests for that. |
Codecov Report
@@ Coverage Diff @@
## develop #550 +/- ##
===========================================
- Coverage 95.13% 94.72% -0.42%
===========================================
Files 49 42 -7
Lines 2613 2557 -56
===========================================
- Hits 2486 2422 -64
- Misses 127 135 +8
Continue to review full report at Codecov.
|
tests/unit/tests_standard_lib/test_requirement_tests/test_test_generator.py
Show resolved
Hide resolved
Expected release notes (by @hsekowski-splunk) features: fixes: others (will not be included in Semantic-Release notes):
|
No description provided.