Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove test_events_with_untokenised_values from RequirementBasic #543

Merged
2 commits merged into from
Feb 17, 2022
Merged

refactor: remove test_events_with_untokenised_values from RequirementBasic #543

2 commits merged into from
Feb 17, 2022

Conversation

artemrys
Copy link
Member

There is no need to run test_events_with_untokenised_values test when running
requirement tests. It is needed when running knowledge tests.

@artemrys artemrys requested a review from a user February 17, 2022 13:09
@ghost ghost requested a review from nandinivij February 17, 2022 13:09
@nandinivij
Copy link
Contributor

nandinivij commented Feb 17, 2022

All the Test_Matrix are failing. As we are not running untokenized events test. We will need to remove it from each requirement functional test https://github.com/artemrys/pytest-splunk-addon/blob/a8f853331e03eb665f638426e7e60a437cb5881c/tests/constants.py#L773

…Basic

There is no need to run test_events_with_untokenised_values test when running
requirement tests. It is needed when running knowledge tests.
@ghost
Copy link

ghost commented Feb 17, 2022

All the Test_Matrix are failing. As we are not running untokenized events test. We will need to remove it from each requirement functional test https://github.com/artemrys/pytest-splunk-addon/blob/a8f853331e03eb665f638426e7e60a437cb5881c/tests/constants.py#L773

Oops, sorry, I removed that line you pointed. Let's wait for the tests to finish.

@nandinivij
Copy link
Contributor

All the Test_Matrix are failing. As we are not running untokenized events test. We will need to remove it from each requirement functional test https://github.com/artemrys/pytest-splunk-addon/blob/a8f853331e03eb665f638426e7e60a437cb5881c/tests/constants.py#L773

Oops, sorry, I removed that line you pointed. Let's wait for the tests to finish.

It will required to be removed in each test.

All the Test_Matrix are failing. As we are not running untokenized events test. We will need to remove it from each requirement functional test https://github.com/artemrys/pytest-splunk-addon/blob/a8f853331e03eb665f638426e7e60a437cb5881c/tests/constants.py#L773

Oops, sorry, I removed that line you pointed. Let's wait for the tests to finish.
Sorry, I meant to remove it from all PASSED reqtest constant
TA_REQUIREMENTS_PASSED = [
"test_splunk_app_requirements.py::Test_App::test_events_with_untokenised_values PASSED",
"test_splunk_app_requirements.py::Test_App::test_requirement_params PASSED*",
]

TA_REQUIREMENTS_MODINPUT_PASSED = [
"test_splunk_app_requirements_modinput.py::Test_App::test_events_with_untokenised_values PASSED",
"test_splunk_app_requirements_modinput.py::Test_App::test_requirement_params PASSED*",
]

TA_REQUIREMENTS_UF_PASSED = [
"test_splunk_app_requirements_uf.py::Test_App::test_events_with_untokenised_values PASSED",
"test_splunk_app_requirements_uf.py::Test_App::test_requirement_params PASSED*",
]

TA_REQUIREMENTS_SCRIPTED_PASSED = [
"test_splunk_app_requirements_scripted.py::Test_App::test_events_with_untokenised_values PASSED",*
"test_splunk_app_requirements_scripted.py::Test_App::test_requirement_params PASSED*",
]

@ghost ghost merged commit 23deab5 into splunk:main Feb 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2022
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants