Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix semgrep issues #558

Merged
1 commit merged into from
Feb 22, 2022
Merged

chore: fix semgrep issues #558

1 commit merged into from
Feb 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2022

This PR fixes the semgrep failures.

@ghost ghost force-pushed the chore/fix-semgrep-issues branch from 5574704 to d39e214 Compare February 21, 2022 17:38
@github-actions
Copy link
Contributor

Expected release notes (by @arys-splunk)

features:
remove splunk-appinspect dependency (#499) (a56e9d1)

others (will not be included in Semantic-Release notes):
fix semgrep issues (d39e214)
make tests run in parallel (#553) (acfddc8)
move test_cim_report.py to unit tests (#554) (43365bf)
add pyupgrade and isort to pre-commit (#552) (5acb649)
clean up helmut after initial refactoring (#544) (eb940bc)
3.0.0-beta.1 (d17c293)
remove test_events_with_untokenised_values from RequirementBasic (#543) (23deab5)
remove matrix option from test-splunk-matrix step (#545) (5464510)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@codecov-commenter
Copy link

Codecov Report

Merging #558 (d39e214) into develop (acfddc8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #558   +/-   ##
========================================
  Coverage    94.72%   94.72%           
========================================
  Files           42       42           
  Lines         2557     2557           
========================================
  Hits          2422     2422           
  Misses         135      135           
Impacted Files Coverage Δ
...ndard_lib/event_ingestors/file_monitor_ingestor.py 100.00% <100.00%> (ø)
...standard_lib/event_ingestors/hec_event_ingestor.py 100.00% <100.00%> (ø)
...tandard_lib/event_ingestors/hec_metric_ingestor.py 100.00% <100.00%> (ø)
...n/standard_lib/event_ingestors/hec_raw_ingestor.py 100.00% <100.00%> (ø)
..._lib/event_ingestors/requirement_event_ingester.py 54.25% <100.00%> (ø)
...n/standard_lib/requirement_tests/test_generator.py 70.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfddc8...d39e214. Read the comment docs.

@ghost ghost marked this pull request as ready for review February 21, 2022 19:13
@ghost ghost requested review from uoboda-splunk and hsekowski-splunk February 21, 2022 19:14
@ghost ghost merged commit 6c8bb63 into develop Feb 22, 2022
@ghost ghost deleted the chore/fix-semgrep-issues branch February 22, 2022 10:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants