chore(exceptions): Fix up what exceptions are thrown #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effor to clean up logs to improve signal to noise ratio of bug vs non-essential/expected failures: * clean up what exceptions are thrown from a bunch of places * anything deriving from UserException won't get logged as a failure * for now, change capacity short circuit to warn instead of error because it is mostly noise. I will work on making it provide accurate signal separately
maggieneterval
approved these changes
Jul 24, 2020
| @@ -82,7 +84,7 @@ class ClusterSizePreconditionTask extends AbstractCloudProviderAwareTask impleme | |||
| errors << 'Missing regions' | |||
| } | |||
| if (errors) { | |||
| throw new IllegalStateException("Invalid configuration " + errors.join(',')) | |||
| throw new ConfigurationException("Invalid configuration " + errors.join(',')) | |||
There was a problem hiding this comment.
Suggested change
| throw new ConfigurationException("Invalid configuration " + errors.join(',')) | |
| throw new ConfigurationException("Invalid configuration " + errors.join(', ')) |
just to be consistent with line 136?
| this.errors = errors; | ||
| } | ||
|
|
||
| public PipelineTemplateValidationException( |
There was a problem hiding this comment.
Do we need all these constructors?
There was a problem hiding this comment.
silly copy-paste, thank you! removing a bunch of them
| import java.util.Collections; | ||
| import java.util.Map; | ||
|
|
||
| public class PipelineTemplateValidationException extends UserException |
There was a problem hiding this comment.
Suggested change
| public class PipelineTemplateValidationException extends UserException | |
| public final class PipelineTemplateValidationException extends UserException |
marchello2000
added a commit
to marchello2000/orca
that referenced
this pull request
Jul 28, 2020
I made changes in my previous PR (spinnaker#3835) to throw a new exception, but didn't update the catch so this is not again generating noise
mergify bot
added a commit
that referenced
this pull request
Jul 28, 2020
I made changes in my previous PR (#3835) to throw a new exception, but didn't update the catch so this is not again generating noise Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
* chore(exceptions): Fix up what exceptions are thrown In an effor to clean up logs to improve signal to noise ratio of bug vs non-essential/expected failures: * clean up what exceptions are thrown from a bunch of places * anything deriving from UserException won't get logged as a failure * for now, change capacity short circuit to warn instead of error because it is mostly noise. I will work on making it provide accurate signal separately * fixup! chore(exceptions): Fix up what exceptions are thrown
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
I made changes in my previous PR (spinnaker#3835) to throw a new exception, but didn't update the catch so this is not again generating noise Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jervi
added a commit
to jervi/orca
that referenced
this pull request
Feb 8, 2021
Template validation errors are supposed to bubble up to the surface, but this broke in spinnaker#3835. This PR brings them back.
jervi
added a commit
to jervi/orca
that referenced
this pull request
Mar 15, 2021
Template validation errors are supposed to bubble up to the surface, but this broke in spinnaker#3835. This PR brings them back.
mergify bot
added a commit
that referenced
this pull request
Dec 4, 2021
* fix(pipeline): Bring back template validation messages in Deck Template validation errors are supposed to bubble up to the surface, but this broke in #3835. This PR brings them back. * Trigger new build Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Chris Thielen <christopherthielen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effor to clean up logs to improve signal to noise ratio of bug vs non-essential/expected failures: