Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): Bring back template validation messages in Deck #4061

Merged
merged 11 commits into from
Dec 4, 2021

Conversation

jervi
Copy link
Contributor

@jervi jervi commented Feb 8, 2021

Template validation errors are supposed to bubble up to the surface, but this broke in #3835. This PR brings them back.

Before:
image

After:
image

@jervi
Copy link
Contributor Author

jervi commented Feb 15, 2021

@spinnaker/oss-reviewers PTAL

@jervi
Copy link
Contributor Author

jervi commented Feb 17, 2021

@marchello2000 🙏

@jervi
Copy link
Contributor Author

jervi commented Mar 3, 2021

@spinnaker/oss-reviewers Anyone?

Template validation errors are supposed to bubble up to the surface, but this broke in spinnaker#3835. This PR brings them back.
@jervi jervi force-pushed the fix_template_validation_errors branch from db20e98 to 1dcbfec Compare March 15, 2021 09:21
@jervi
Copy link
Contributor Author

jervi commented Aug 31, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2021

Command update: success

Branch has been successfully updated

@mattgogerly mattgogerly added the ready to merge Approved and ready for merge label Dec 4, 2021
@mergify mergify bot added the auto merged Merged automatically by a bot label Dec 4, 2021
@mergify mergify bot merged commit f0d5477 into spinnaker:master Dec 4, 2021
@jervi jervi deleted the fix_template_validation_errors branch December 7, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.28
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants