-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pipeline): Bring back template validation messages in Deck #4061
Merged
mergify
merged 11 commits into
spinnaker:master
from
jervi:fix_template_validation_errors
Dec 4, 2021
Merged
fix(pipeline): Bring back template validation messages in Deck #4061
mergify
merged 11 commits into
spinnaker:master
from
jervi:fix_template_validation_errors
Dec 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@spinnaker/oss-reviewers PTAL |
@spinnaker/oss-reviewers Anyone? |
Template validation errors are supposed to bubble up to the surface, but this broke in spinnaker#3835. This PR brings them back.
db20e98
to
1dcbfec
Compare
0xkarmacoma
approved these changes
Aug 25, 2021
@Mergifyio update |
Command
|
mattgogerly
approved these changes
Nov 29, 2021
christopherthielen
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto merged
Merged automatically by a bot
ready to merge
Approved and ready for merge
target-release/1.28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template validation errors are supposed to bubble up to the surface, but this broke in #3835. This PR brings them back.
Before:

After:
