chore(exceptions): Fix up what exceptions are thrown #3835
+116
−35
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,64 @@ | ||||||
| /* | ||||||
| * Copyright 2020 Netflix, Inc. | ||||||
| * | ||||||
| * Licensed under the Apache License, Version 2.0 (the "License") | ||||||
| * you may not use this file except in compliance with the License. | ||||||
| * You may obtain a copy of the License at | ||||||
| * | ||||||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||||||
| * | ||||||
| * Unless required by applicable law or agreed to in writing, software | ||||||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||||||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
| * See the License for the specific language governing permissions and | ||||||
| * limitations under the License. | ||||||
| */ | ||||||
|
|
||||||
| package com.netflix.spinnaker.orca.exceptions; | ||||||
|
|
||||||
| import com.netflix.spinnaker.kork.exceptions.HasAdditionalAttributes; | ||||||
| import com.netflix.spinnaker.kork.exceptions.UserException; | ||||||
| import java.util.Collection; | ||||||
| import java.util.Collections; | ||||||
| import java.util.Map; | ||||||
|
|
||||||
| public class PipelineTemplateValidationException extends UserException | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| implements HasAdditionalAttributes { | ||||||
| private final Collection errors; | ||||||
|
|
||||||
| public PipelineTemplateValidationException(Collection errors) { | ||||||
| this.errors = errors; | ||||||
| } | ||||||
|
|
||||||
| public PipelineTemplateValidationException(String message, Collection errors) { | ||||||
| super(message); | ||||||
| this.errors = errors; | ||||||
| } | ||||||
|
|
||||||
| public PipelineTemplateValidationException(String message, Throwable cause, Collection errors) { | ||||||
| super(message, cause); | ||||||
| this.errors = errors; | ||||||
| } | ||||||
|
|
||||||
| public PipelineTemplateValidationException(Throwable cause, Collection errors) { | ||||||
| super(cause); | ||||||
| this.errors = errors; | ||||||
| } | ||||||
|
|
||||||
| public PipelineTemplateValidationException( | ||||||
|
There was a problem hiding this comment. Do we need all these constructors? There was a problem hiding this comment. silly copy-paste, thank you! removing a bunch of them |
||||||
| String message, | ||||||
| Throwable cause, | ||||||
| boolean enableSuppression, | ||||||
| boolean writableStackTrace, | ||||||
| Collection errors) { | ||||||
| super(message, cause, enableSuppression, writableStackTrace); | ||||||
| this.errors = errors; | ||||||
| } | ||||||
|
|
||||||
| @Override | ||||||
| public Map<String, Object> getAdditionalAttributes() { | ||||||
| return errors != null && !errors.isEmpty() | ||||||
| ? Collections.singletonMap("errors", errors) | ||||||
| : Collections.emptyMap(); | ||||||
| } | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Copyright 2020 Netflix, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License") | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.netflix.spinnaker.orca.exceptions; | ||
|
|
||
| import com.netflix.spinnaker.kork.exceptions.UserException; | ||
|
|
||
| public class PreconditionFailureException extends UserException { | ||
| public PreconditionFailureException(String message) { | ||
| super(message); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be consistent with line 136?