Adjusts the chat name color palette to be properly high-contrast #24567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the colors are good but having so few colors is a bit of an issues since they will be reused quite frequently. Even if it's at the expensive of being consistently readable between all options, having more colors would be better. |
|
Converting to draft; waiting on #24562 before we work on this further, as that opens the door to more ideal accessibility |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR / Why
The colors in #24478 are particularly problematic for pretty much everyone due to the low contrast with the chat background, even with #24555.
So this PR replaces the bootleg Material Design palette with a far more distinct 8-color palette that we golfed and whipped up on the spot. This palette is designed to be reasonably high contrast (though proper text outlines would be ideal on top of this, as high-noise backgrounds can still cause readability issues with these). Additionally, the first 5 colors of the palette, the Daltonic colors, are chosen specifically for colorblind compatibility.
For the sake of maintaining parity with the material palette (which contains 8 unique colors excluding the different-luminosity variants), three extra colors are bolted on.
Technical details
N/A
Media
Old daltonic palette
Normal Vision
Protanopia
Deuteranopia
Tritanopia
Blue cone monochromacy
Breaking changes
N/A
Changelog
🆑 Bhijn and Myr