Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports colored chat names #24478

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Ports colored chat names #24478

merged 2 commits into from
Jan 25, 2024

Conversation

ike709
Copy link
Contributor

@ike709 ike709 commented Jan 24, 2024

About the PR

Ports space-syndicate/space-station-14#844

I think this makes it much easier to follow what people are saying, and when we have the technology for runechat that looks good we can color it there like in SS13.

I'm pretty indifferent about what the actual color options are so bikeshed as much as you please.

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Morty, ike709

  • add: Names are now colored in chat.

@Kadeo64
Copy link
Contributor

Kadeo64 commented Jan 24, 2024

do we get to choose our chat color or nah

@mirrorcult
Copy link
Contributor

how does it work with identity rn

@mirrorcult
Copy link
Contributor

do we get to choose our chat color or nah

dont think its necessary imo

@mirrorcult
Copy link
Contributor

at least not for initial pr

Comment on lines 331 to 332

const string paletteId = "Material";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValidatePrototypeId attribute exists if you want to hardcode a prototype.

@ike709
Copy link
Contributor Author

ike709 commented Jan 25, 2024

how does it work with identity rn

Here's how it works now with a voice changer:

image

@ike709 ike709 requested a review from metalgearsloth January 25, 2024 05:17
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 25, 2024
@deathride58
Copy link
Member

Does this color the speech bubble name as well?

@Emisse
Copy link
Contributor

Emisse commented Jan 25, 2024

im going senile i cant read chat its all white i have to merge this now

@Emisse Emisse merged commit 6cbe4a8 into space-wizards:master Jan 25, 2024
11 checks passed
@Errant-4
Copy link
Member

Nice!
But is it intentional that department channel color overwrites the name color? Names in emotes are also not colored, is that because this is supposed to represent voice only?

@SlamBamActionman
Copy link
Member

This was merged before proper testing, and the screenshot in the PR does not accurately reflect how it looks ingame. There is a thread on Discord with multiple examples of how the current color selection is detrimental to the readability of chat. https://discord.com/channels/310555209753690112/1200030805095895050

Revert this PR or get a hotfix out to fix the colors/make it optional.

@SlamBamActionman
Copy link
Member

SlamBamActionman commented Jan 25, 2024

image-7

One of the examples. Ite Dino's first message is the worst blended, but even still the others require effort to discern at a glance.

@GreyMario
Copy link
Contributor

very accessible thanks i'm so glad i'm not colorblind

@SlamBamActionman
Copy link
Member

For those that need visuals for the comment above, here are examples of various color blindness using the edited bg from #24555:

Original:
299670854-3ed313c5-07ce-40c0-b75f-7be4dda776c2

Deutan:
pilestone jpg (3)

Protan:
pilestone jpg (4)

Tritan:
pilestone jpg (5)

I also recommend to try reading the text while squinting; it can help determine if certain color contrasts blend in too much in the background.

@juliangiebel
Copy link
Contributor

As Ike mentioned here:

I'm pretty indifferent about what the actual color options are so bikeshed as much as you please.

The colors aren't specifically chosen so feel free to open a PR that sets the colors to an accessible color pallet. Posting additional comments on this PR won't help and eventually just get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants