-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports colored chat names #24478
Ports colored chat names #24478
Conversation
do we get to choose our chat color or nah |
how does it work with identity rn |
dont think its necessary imo |
at least not for initial pr |
|
||
const string paletteId = "Material"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ValidatePrototypeId attribute exists if you want to hardcode a prototype.
Does this color the speech bubble name as well? |
im going senile i cant read chat its all white i have to merge this now |
Nice! |
This was merged before proper testing, and the screenshot in the PR does not accurately reflect how it looks ingame. There is a thread on Discord with multiple examples of how the current color selection is detrimental to the readability of chat. https://discord.com/channels/310555209753690112/1200030805095895050 Revert this PR or get a hotfix out to fix the colors/make it optional. |
very accessible thanks i'm so glad i'm not colorblind |
For those that need visuals for the comment above, here are examples of various color blindness using the edited bg from #24555: I also recommend to try reading the text while squinting; it can help determine if certain color contrasts blend in too much in the background. |
As Ike mentioned here:
The colors aren't specifically chosen so feel free to open a PR that sets the colors to an accessible color pallet. Posting additional comments on this PR won't help and eventually just get lost. |
About the PR
Ports space-syndicate/space-station-14#844
I think this makes it much easier to follow what people are saying, and when we have the technology for runechat that looks good we can color it there like in SS13.
I'm pretty indifferent about what the actual color options are so bikeshed as much as you please.
Media
Changelog
🆑 Morty, ike709