Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species Reworks #19450

Closed
wants to merge 34 commits into from
Closed

Species Reworks #19450

wants to merge 34 commits into from

Conversation

LankLTE
Copy link
Contributor

@LankLTE LankLTE commented Aug 23, 2023

I will re-add and fill in the rest of the details once this is closer to being finished. For the what and why, look at this design doc, under "Race Rework Proposal." If there's a problem with any of the designs I've outlined, please tell me before I decide to go and code it all.

As for what actually needs to be done (I've gone through and laid this out in the order I intend to do it):

Moths:

  • Numerical Changes

Diona:

  • Numerical Changes
  • Basic Nymph Mob
  • Spawning Nymphs on death
  • Transferring mind to allow borging
  • Fire stacks from heat damage
  • Spawning Nymphs on command
  • Action to gib self after death
  • Nymph Reforming

Lizards:

  • Numerical Changes
  • Dragging with Tail
  • Restrict diet to Meat and Fruit

Slimes:

  • Numerical Changes
  • Passive Regen
  • Reform from Brain

Final Bit I should do:

  • Admin logs for reforming and spawning nymphs

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

@LankLTE LankLTE marked this pull request as draft August 23, 2023 17:47
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

RSI Diff Bot; head commit dfe57bb merging into a6bed0f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Animals/nymph.rsi

State Old New Status
icon Added
nymph Added
nymph_dead Added
nymph_sleep Added

Edit: diff updated after dfe57bb

@NancokPS2
Copy link

NancokPS2 commented Aug 23, 2023

Reviving after death (for both slimes and diona) seems busted overall. Creating more players even more so.
If the nymphs are limited enough it could be a fun feature tho

Thing is, memories SHOULD be lost. Getting to revive with your memories ruins a lot of game dynamics.

Also, breathing CO2 kinda ruins some antag strats entirely, but i guess it is fair for a race that is so slow

@CrigCrag
Copy link
Contributor

diona can already breath CO2

@LankLTE
Copy link
Contributor Author

LankLTE commented Aug 23, 2023

Reviving after death seems busted overall. Creating more players even more so. Not from a balance perspecrive, but because it simply messes with the game's dynamic. Also, breathing CO2 kinda ruins some antag strats entirely, but i guess it is fair for a race that is so slow

Diona breathing CO2 is already a thing.
Reviving after death is something I'm trying to do in a balanced way. To put it simply gibbing a body or spacing it will still work- all this will really counter is leaving the body in maints and hoping people don't find it before it rots (which is lame anyways in my opinion), especially for a race with that many downsides. Making new players is also gonna be balanced in a way to make it relatively uncommon- I don't want ghost roles being spammed.

@Anzarot121
Copy link
Contributor

I've read in your document especially arachnids. Damn it, this is a species created purely for power gaming, they have no cons at all. They are faster without meth than humans under meth, stronger, have 4 arms, feel hunger and thirst less often than humans.

@NancokPS2
Copy link

Diona breathing CO2 is already a thing. Reviving after death is something I'm trying to do in a balanced way. To put it simply gibbing a body or spacing it will still work- all this will really counter is leaving the body in maints and hoping people don't find it before it rots (which is lame anyways in my opinion), especially for a race with that many downsides. Making new players is also gonna be balanced in a way to make it relatively uncommon- I don't want ghost roles being spammed.

My bad on Dionas.

But dying should not be this meaningless and this is just busted even if delayed. Getting jumped in maints is part of the maints experience. It is already pretty trivial to revive people.

Without mentioning that waiting a while is very un-engaging.

@LankLTE
Copy link
Contributor Author

LankLTE commented Aug 23, 2023

I've read in your document especially arachnids. Damn it, this is a species created purely for power gaming, they have no cons at all.

They no longer move faster- the document doesn't say they do either. I still think their upsides far outweigh their downsides, however.

Getting to revive with your memories ruins a lot of game dynamics.

This is already how reviving works..? Defibbing works like this (and slimes, diona and moths currently don't rot, so they can be ghosted for literally an hour just to get revived and keep their memories. Cloning also works like this, and that's literally getting a different body. Diona are supposed to be made of several nymphs combined- it only makes sense they would keep memories.

@LankLTE
Copy link
Contributor Author

LankLTE commented Aug 23, 2023

But dying should not be this meaningless and this is just busted even if delayed. Getting jumped in maints is part of the maints experience. It is already pretty trivial to revive people.

Without mentioning that waiting a while is very un-engaging.

If you get jumped in maints the person who jumped you is fully capable of killing a nymph that moves slower than a player and has 30 health when it spawns. Nymphs are also able to move around and say stuff still, so it isn't like you can't do anything. Slimes are sort of a different story, since they're technically doing "nothing" while waiting to reform, but you're already perma-dead when gibbed normally anyways so to the idea is you'll chill a bit as a ghost before reforming.

@NancokPS2
Copy link

NancokPS2 commented Aug 23, 2023

I think nymphs are fine since you just create your own ghost role, my issue are slimes.

Dying is part of the game, no one should get to circumvent that on their own.
Specially not by just selecting a race at round start, if this is added slimes should not be eligible as a round start race.

@Anzarot121
Copy link
Contributor

I think nymphs are fine since you just create your own ghost role, my issue are slimes.

Dying is part of the game, no one should get to circumvent that on their own. Specially not by just selecting a race at round start, if this is added slimes should not be eligible as a round start race.

Then no one other than humans should be the roundstart race.

@Aisu9
Copy link

Aisu9 commented Aug 23, 2023

is this possible to borg dionas and slimes? because if they cannot i do think the "self" revive mechanic is good, they should tho in a sense be less than what they were and still count as dead for syndicates objectives

@Interrobang01
Copy link
Contributor

Interrobang01 commented Aug 23, 2023

shouldn't this be split into 1 pr per species change, instead of all of the changes at once? (pr is unfinished obviously but i feel like it might be an issue once done)

@LankLTE
Copy link
Contributor Author

LankLTE commented Aug 23, 2023

is this possible to borg dionas and slimes? because if they cannot i do think the "self" revive mechanic is good, they should tho in a sense be less than what they were and still count as dead for syndicates objectives

"still count as dead for syndicates objectives" defeats the entire point. This is supposed to be an upside. if cloning doesn't count as dead this shouldn't either. You can very easily throw the slime core into space or just keep it on you, and I've talked before about how Nymphs are easy to kill.

shouldn't this be split into 1 pr per species change, instead of all of the changes at once? (pr is unfinished obviously but i feel like it might be an issue once done)

Maybe, this just felt fitting since it addresses two issues on github and follows one design doc. If maints wish I can split it pretty easily

@Aisu9
Copy link

Aisu9 commented Aug 23, 2023

"still count as dead for syndicates objectives" defeats the entire point. This is supposed to be an upside. if cloning doesn't count as dead this shouldn't either. You can very easily throw the slime core into space or just keep it on you, and I've talked before about how Nymphs are easy to kill.

yeah but if they can't be borged what would be their alternatives for half-revive? other than self revive that can be prevented by PK them by throwing the self regenerative stuff in space? it exist but is frown upon even on Lizard for information. so you just want these two species to be permanently killable very easily but still giving them a false chance to survive?

@LankLTE
Copy link
Contributor Author

LankLTE commented Aug 23, 2023

these two species to be permanently killable very easily.

They're just as easy (or difficult) to perma kill as every other species. I don't really see how this is a point. They can still be borged, but people are discouraged from doing it to slimes as they have a way to revive themselves.

@VasilisThePikachu
Copy link
Member

Im gonna join the argument against self revives, this will just encourage spacing and gibbing bodies which i see as good and bad.

But being able to self revive gets rid of the reason of med to do that for you. I think its better if it required at least some kind of other player interaction first. This may also feel unfair to species without the revive ability, why can they get to play the game after a bit of timeout while they sit in a locker dead for the rest of the round?

@BolloTea
Copy link

why do then any features of the races, if they give certain advantages?

@BolloTea
Copy link

If you are confused by the "indestructibility" of the slime core, then do not forget about cremation. Besides, I'm more than sure that it will be possible to do other ways of final killing. To me, this is just a small test for the antagonists, which will make them think more radically.

@LankLTE
Copy link
Contributor Author

LankLTE commented Aug 25, 2023

But being able to self revive gets rid of the reason of med to do that for you.

Med is already fully incapable of reviving gibbed bodies. The slimes rework doesn’t take anything away from them. The diona rework I intend to do in a way that getting revived via Nymph is worse than being revived normally and it’s something you’ll only do if you have to. I don’t see how this is removing med gameplay at all.

This may also feel unfair to species without the revive ability, why can they get to play the game after a bit of timeout while they sit in a locker dead for the rest of the round?

Because they picked a different race and they have different upsides? You could make this argument for race upsides that are already in the game. Why do humans get to use emergency suits for a super long time when Lizards die almost instant after using it? Why do other classes have to suffocate so quickly when slimes take forever?

@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Aug 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 1, 2023
@Anzarot121
Copy link
Contributor

Since you asked for an alternative: The major problem right now (ignoring any fairness arguments) is that for a permanent kill you need to space the body

They do not rot and recover when gibbed which means they are unkillable outside of that. This completely fucks antags if they cannot drag the body to an airlock and open it to space the body, it will eventually regenerate and out them.

Here are some toughts:

-Slimes, on death, dissolve into a brain or core over a minute, which can be sped up by hitting them or by using a verb to extract it from the body. This core can be smashed to permanently kill them.

This core never rots and can be quickly revived with a defibrilator. Meaning that slimes are VERY easy to revive and even bring to medbay. But they are easy to kill for good.

The self reviving sounds way more doable if they are easier to perma than others

Edit: apparently the no rotting part was a bug? I cannot remember rn. I at least they could be made to not rot with this idea since it would be more than fair.

You can simply hoist the humanoid on the hook and dismantle the hook. To do this, you will need 12 seconds and several sheets of steel.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 4, 2023
@LankLTE
Copy link
Contributor Author

LankLTE commented Sep 6, 2023

I'll be splitting this into separate PRs soonish, so the lizard and moth changes can get thrown in while I figure out what the fuck is happening with reforming.

@Froozigiusz
Copy link
Contributor

I'll be splitting this into separate PRs soonish, so the lizard and moth changes can get thrown in while I figure out what the fuck is happening with reforming.

Good to see #20328 coming out of this project, makes me really hopeful about a fruitful future for dionæ kind.

@LankLTE
Copy link
Contributor Author

LankLTE commented Dec 15, 2023

Half already in the game, half derelict. Might finish diona eventually but don't get your hopes up.

@LankLTE LankLTE closed this Dec 15, 2023
@UbaserB
Copy link
Member

UbaserB commented Dec 15, 2023

I pray 🙏🏻

@Froozigiusz Froozigiusz mentioned this pull request Jan 3, 2024
8 tasks
@K-Dynamic
Copy link
Contributor

I pray 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.