[ VRF ] Returned t0 configuration for run vrf cases

[SavchukRomanLv]

Signed-off-by: Roman Savchuk romanx.savchuk@intel.com

Description of PR

As described in #2538, when run vrf test suite "AnsibleUndefinedVariable: 'dict object' has no attribute 'podset_number'" appears. The reason is that these attributes were deleted from topo_t0.yml by commit #1233

Summary:
Return back needed configuration for VRF test cases. Fixes #2468

Type of change

• [+ ] Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Approach

What is the motivation for this PR?

Want to have ability to run full VRF test suite

How did you do it?

Returned required configuration of t0 for VRF TC.

How did you verify/test it?

Run cases which requires t0 changes:
vrf/test_vrf.py::TestVrfIsolation::test_neigh_isolate_vrf1_from_vrf2 PASSED vrf/test_vrf.py::TestVrfIsolation::test_neigh_isolate_vrf2_from_vrf1 PASSED vrf/test_vrf.py::TestVrfIsolation::test_fib_isolate_vrf1_from_vrf2 PASSED vrf/test_vrf.py::TestVrfIsolation::test_fib_isolate_vrf2_from_vrf1 PASSED

Any platform specific information?

SONiC Software Version: SONiC.master.35-dirty-20201112.031542
Distribution: Debian 10.6
Kernel: 4.19.0-9-2-amd64
Build commit: 6c362a08
Build date: Thu Nov 12 11:49:55 UTC 2020
Platform: x86_64-accton_wedge100bf_32x-r0
HwSKU: montara
ASIC: barefoot

Supported testbed topology if it's a new test case?

Documentation

[SavchukRomanLv]

retest vsimage please

[NazarTkachuk]

Pls review @wangxin @yxieca

[wangxin]

Currently these variables are defined in the fib plugin for announcing routes. If define them again in topo file, there are two sources of these information. However, I feel that topo file is a better place for these definitions. The fib plugin can try to get values from topo file. If no value is in topo file, then the fib plugin can fallback to use default value. So, more changes are needed to make it complete.

• Update the fib plugin
• Add the definitions to other topo files as well.

Can you make those changes as well?

[SavchukRomanLv]

Currently these variables are defined in the fib plugin for announcing routes. If define them again in topo file, there are two sources of these information. However, I feel that topo file is a better place for these definitions. The fib plugin can try to get values from topo file. If no value is in topo file, then the fib plugin can fallback to use default value. So, more changes are needed to make it complete.

• Update the fib plugin
• Add the definitions to other topo files as well.

Can you make those changes as well?

@wangxin make changes in latest commit.
Test it on two topo:
announced 25613 routes on t0, fib TC passed
announced 82877 routes on t1, arp TC passed

[lgtm-com]

This pull request introduces 4 alerts when merging 511e16f into 9df3f25 - view on LGTM.com

new alerts:

• 4 for Wrong number of arguments in a call