Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the BGP Bounce Back Routing test script #2538

Merged
merged 6 commits into from
Nov 25, 2020
Merged

Implement the BGP Bounce Back Routing test script #2538

merged 6 commits into from
Nov 25, 2020

Conversation

wangxin
Copy link
Collaborator

@wangxin wangxin commented Nov 16, 2020

Description of PR

Summary:
Fixes # (issue)

Implement the BGP Bounce Back Routing test script

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

The BGP Bounce Back Routing (BBR) feature has been introduced into SONiC.
This change is to implement a test script for testing this BGP BBR feature.

How did you do it?

This test requires T1 type topology. Added 3 test cases:

Test Case1

  • BBR is enabled (by default), announce a route to the first T0 VM. The route has DUT asn in aspath.
  • Verify that the route is accepted by DUT and propagated to other VMs.

Test Case2

  • BBR is enabled (by default), announce a route to the first T0 VM. The route has two DUT asn in aspath.
  • Verify that the route is not accepted by DUT and not propagated to other VMs.

Test Case3

  • Disable BBR, announce a route to the first T0 VM. The route has DUT asn in aspath.
  • Verify that the route is not accepted by DUT and not propagated to other VMs.
  • Enable BBR again after test.

How did you verify/test it?

Test run the script on vs setup running t1-lag topology and 201911 image.

Any platform specific information?

Supported testbed topology if it's a new test case?

t1 type topology

Documentation

sonic-net/sonic-buildimage#5626

@wangxin wangxin requested review from pavel-shirshov and a team November 16, 2020 07:20
@wangxin
Copy link
Collaborator Author

wangxin commented Nov 16, 2020

Because of issue sonic-net/sonic-buildimage#5929, this PR is still in draft.

@wangxin wangxin marked this pull request as ready for review November 17, 2020 03:57
Copy link
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check my comments?

The BGP Bounce Back Routing (BBR) feature has been introduced into SONiC.
This change is to implment a test script for testing this BGP BBR feature.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
* Use defaultdict
* Merge two alike fixtures into a single one to avoid duplication
* Move functions for checkout single route to device classes

Signed-off-by: Xin Wang
@pavel-shirshov
Copy link
Contributor

retest vsimage please

Copy link
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is to ensure that bbr enabled test cases are not affected by default BBR setting.
@wangxin wangxin merged commit ea03eac into sonic-net:master Nov 25, 2020
wangxin pushed a commit that referenced this pull request Nov 30, 2020
As described in #2538, when run vrf test suite "AnsibleUndefinedVariable: 'dict object' has no attribute 'podset_number'" appears. The reason is that these attributes were deleted from topo_t0.yml by commit #1233

Changes:
* Removed all hardcoded values from fib plugin.
* Added missed params to all topo files
* Updated generate_routes method, removed hardcoded values for decap case.

Signed-off-by: Roman Savchuk <romanx.savchuk@intel.com>
@wangxin wangxin deleted the bgp_bbr branch November 30, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants