-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the BGP Bounce Back Routing test script #2538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of issue sonic-net/sonic-buildimage#5929, this PR is still in draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please check my comments?
The BGP Bounce Back Routing (BBR) feature has been introduced into SONiC. This change is to implment a test script for testing this BGP BBR feature. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
* Use defaultdict * Merge two alike fixtures into a single one to avoid duplication * Move functions for checkout single route to device classes Signed-off-by: Xin Wang
3 tasks
retest vsimage please |
pavel-shirshov
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is to ensure that bbr enabled test cases are not affected by default BBR setting.
2 tasks
wangxin
pushed a commit
that referenced
this pull request
Nov 30, 2020
As described in #2538, when run vrf test suite "AnsibleUndefinedVariable: 'dict object' has no attribute 'podset_number'" appears. The reason is that these attributes were deleted from topo_t0.yml by commit #1233 Changes: * Removed all hardcoded values from fib plugin. * Added missed params to all topo files * Updated generate_routes method, removed hardcoded values for decap case. Signed-off-by: Roman Savchuk <romanx.savchuk@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Implement the BGP Bounce Back Routing test script
Type of change
Approach
What is the motivation for this PR?
The BGP Bounce Back Routing (BBR) feature has been introduced into SONiC.
This change is to implement a test script for testing this BGP BBR feature.
How did you do it?
This test requires T1 type topology. Added 3 test cases:
Test Case1
Test Case2
Test Case3
How did you verify/test it?
Test run the script on vs setup running t1-lag topology and 201911 image.
Any platform specific information?
Supported testbed topology if it's a new test case?
t1 type topology
Documentation
sonic-net/sonic-buildimage#5626