Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vrf] test_vrf fails due to missing attributes in topo_t0.yml #2468

Closed
AndriiLozovyi opened this issue Nov 5, 2020 · 1 comment · Fixed by #2580
Closed

[Vrf] test_vrf fails due to missing attributes in topo_t0.yml #2468

AndriiLozovyi opened this issue Nov 5, 2020 · 1 comment · Fixed by #2580

Comments

@AndriiLozovyi
Copy link
Contributor

Description:
After running test_vrf some of test cases fail with such error:
"AnsibleUndefinedVariable: 'dict object' has no attribute 'podset_number'".
The reason is that these attributes were deleted from topo_t0.yml by commit #1233

    podset_number: 200
    tor_number: 16
    tor_subnet_number: 2
    max_tor_subnet_number: 16
    tor_subnet_size: 128
    spine_asn: 65534
    leaf_asn_start: 64600
    tor_asn_start: 65100
    failure_rate: 0

These attributes is mainly used in test_vrf by vrf_fib.j2

Steps to reproduce the issue:

  1. Deploy t0 topology.
  2. Deploy minigrapgh on DUT
  3. Run test_vrf.py

Describe the results you received:

E           RunAnsibleModuleFail: run module template failed, Ansible Results =>
E           {"changed": false, "failed": true, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'podset_number'"}

vrf/test_vrf.py::TestVrfIsolation::test_neigh_isolate_vrf1_from_vrf2 ERROR                                                                                       
vrf/test_vrf.py::TestVrfIsolation::test_neigh_isolate_vrf2_from_vrf1 ERROR                                                                                       
vrf/test_vrf.py::TestVrfIsolation::test_fib_isolate_vrf1_from_vrf2 ERROR                                                                                        
vrf/test_vrf.py::TestVrfIsolation::test_fib_isolate_vrf2_from_vrf1 ERROR

Describe the results you expected:

vrf/test_vrf.py::TestVrfIsolation::test_neigh_isolate_vrf1_from_vrf2 PASSED
vrf/test_vrf.py::TestVrfIsolation::test_neigh_isolate_vrf2_from_vrf1 PASSED
vrf/test_vrf.py::TestVrfIsolation::test_fib_isolate_vrf1_from_vrf2 PASSED
vrf/test_vrf.py::TestVrfIsolation::test_fib_isolate_vrf2_from_vrf1 PASSED

Additional information you deem important:

**Output of `show version`:**

```
SONiC Software Version: SONiC.master.22-dirty-20201030.044825
Distribution: Debian 10.6
Kernel: 4.19.0-9-2-amd64
Build commit: b132ca09
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@SavchukRomanLv
Copy link
Contributor

@lguohan could you please take a look? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants