This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Use string for RPC message IDs #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcintyre94
commented
Oct 31, 2024
•
- Still an autoincrementing integer, but sent to the server as a string
- This means the server will return it to us as a string, and we don't need to worry about number/bigint upcasting
- This fixes the bug in subscriptions, caused by upcasting the ID to a bigint
🦋 Changeset detectedLatest commit: feff254 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mcintyre94 and the rest of your teammates on |
04c8897 to
1510982
Compare
steveluscher
suggested changes
Oct 31, 2024
1510982 to
f22aafe
Compare
- Still an autoincrementing integer, but sent to the server as a string - This means the server will return it to us as a string, and we don't need to worry about number/bigint upcasting - This fixes the bug in subscriptions, caused by upcasting the ID to a bigint
de389fd to
feff254
Compare
Merged
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.