Use string for RPC message IDs (#3507)

- Still an autoincrementing integer, but sent to the server as a string
- This means the server will return it to us as a string, and we don't need to worry about number/bigint upcasting
- This fixes the bug in subscriptions, caused by upcasting the ID to a bigint

<img width="329" alt="Screenshot 2024-10-31 at 16 06 51" src="https://github.com/user-attachments/assets/2fc3ccb8-34a9-449d-9fd9-536ebce29b8b">
<img width="426" alt="Screenshot 2024-10-31 at 16 07 32" src="https://github.com/user-attachments/assets/9e107fdc-dcd2-47d0-91be-8cadd98ec85e">

.changeset/funny-weeks-smash.md

@@ -0,0 +1,7 @@
+---
+'@solana/rpc-subscriptions': patch
+'@solana/rpc-spec-types': patch
+'@solana/rpc-spec': patch
+---
+
+Fixed a bug where the subcription server's response would not be detected, because of a mismatch in the format of the `id`. Now all RPC message ids are strings, for avoidance of doubt.

packages/rpc-spec-types/src/__tests__/rpc-message-test.ts

@@ -5,12 +5,12 @@ describe('createRpcMessage', () => {
         const request = { methodName: 'foo', params: 'bar' };
         const { id: firstId } = createRpcMessage(request);
         const { id: secondId } = createRpcMessage(request);
-        expect(secondId - firstId).toBe(1);
+        expect(Number(secondId) - Number(firstId)).toBe(1);
     });
     it('returns a well-formed JSON-RPC 2.0 message', () => {
         const request = { methodName: 'someMethod', params: [1, 2, 3] };
         expect(createRpcMessage(request)).toStrictEqual({
-            id: expect.any(Number),
+            id: expect.any(String),
             jsonrpc: '2.0',
             method: 'someMethod',
             params: [1, 2, 3],

packages/rpc-spec-types/src/rpc-message.ts

@@ -1,10 +1,10 @@
 import { RpcRequest } from './rpc-request';
 
-let _nextMessageId = 0;
-function getNextMessageId() {
+let _nextMessageId = 0n;
+function getNextMessageId(): string {
     const id = _nextMessageId;
-    _nextMessageId = (_nextMessageId + 1) % Number.MAX_SAFE_INTEGER;
-    return id;
+    _nextMessageId++;
+    return id.toString();
 }
 
 export function createRpcMessage<TParams>(request: RpcRequest<TParams>) {

packages/rpc-spec-types/src/rpc-response.ts

@@ -7,7 +7,7 @@ export type RpcResponseTransformer<TResponse = unknown> = {
 };
 
 interface IHasIdentifier {
-    readonly id: number;
+    readonly id: string;
 }
 
 type RpcErrorResponsePayload = Readonly<{

packages/rpc-spec/src/__tests__/rpc-test.ts

@@ -59,7 +59,7 @@ describe('JSON-RPC 2.0', () => {
                 .send()
                 .catch(() => {});
             expect(makeHttpRequest).toHaveBeenCalledWith({
-                payload: { ...createRpcMessage({ methodName: 'someMethod', params: [123] }), id: expect.any(Number) },
+                payload: { ...createRpcMessage({ methodName: 'someMethod', params: [123] }), id: expect.any(String) },
             });
         });
         it('returns results from the transport', async () => {
@@ -99,7 +99,7 @@ describe('JSON-RPC 2.0', () => {
             expect(makeHttpRequest).toHaveBeenCalledWith({
                 payload: {
                     ...createRpcMessage({ methodName: 'someMethodAugmented', params: [123, 'augmented', 'params'] }),
-                    id: expect.any(Number),
+                    id: expect.any(String),
                 },
             });
         });

packages/rpc-subscriptions/src/__tests__/rpc-subscriptions-functional-test.ts

@@ -23,8 +23,7 @@ describe('accountNotifications', () => {
         rpcSubscriptions = createLocalhostSolanaRpcSubscriptions();
     });
 
-    // eslint-disable-next-line jest/no-disabled-tests
-    it.skip('can subscribe to account notifications', async () => {
+    it('can subscribe to account notifications', async () => {
         expect.hasAssertions();
         const abortSignal = new AbortController().signal;
         const subscriptionPromise = rpcSubscriptions