Add a failing test that verifies we can subscribe to an RPC subscription method #3506
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mcintyre94 and the rest of your teammates on |
| // eslint-disable-next-line jest/no-disabled-tests | ||
| it.skip('can subscribe to account notifications', async () => { |
There was a problem hiding this comment.
I think you can actually write this as it.failing instead of skipping it.
There was a problem hiding this comment.
I tried that, but because it fails by timing out it doesn't seem to work.
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
In rc2 there's a bug where
await rpcSubscriptions.anyNotifications().subscribe()hangs. Unlikerpc-apiall tests inrpc-subscriptions-apiare currently commented out.This PR adds a (currently failing) test to subscribe to notifications against the localhost test validator.
Notes:
I've put this test in
rpc-subscriptionsrather thanrpc-subscriptions-apibecause it relies on transport functions fromrpc-subscriptions. If we wanted to build a full suite ofrpc-subscriptions-apitests later then we should probably move these transport functions to a different package where they could be a dependency ofrpc-subscriptions-api. We currently haverpc-transport-httpfor this on therpc-apiside.I used
it.skipinstead ofit.failingbecause the test times out rather than failing, and Jest doesn't treat that as a pass forit.failing. Anyway I don't plan to leave it failing long!