[Plugin] [2/9] Convert throws to asserts #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin-amend-imports-for-readability
…l/plugins-move-throws-to-asserts
tomekzaw
requested changes
Mar 29, 2023
tomekzaw
reviewed
Mar 29, 2023
tomekzaw
reviewed
Mar 29, 2023
tomekzaw
reviewed
Mar 29, 2023
plugin/src/makeWorklet.ts
Outdated
| @@ -370,7 +372,7 @@ export function makeWorklet( | |||
| functionName, | |||
| transformed.map | |||
| ); | |||
| if (!funString) throw new Error("'funString' is not defined\n"); | |||
| assertIsDefined(funString); | |||
There was a problem hiding this comment.
In which case funString is not defined? Is it possible to use TypeScript to ensure that it's defined?
There was a problem hiding this comment.
I don't want to hardcode it since d.ts from Babel says:
So I'd rather leave it as is for now.
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
tjzel
commented
Mar 30, 2023
tomekzaw
approved these changes
Apr 3, 2023
plugin/package.json
Outdated
| @@ -15,7 +16,7 @@ | |||
| "bundle": "yarn esbuild ./lib/plugin.js --bundle --external:@babel --external:convert-source-map --external:fs --external:'../../package.json' --log-level=warning --platform=node --sourcemap=linked --outfile=build/plugin.js", | |||
| "format": "yarn prettier --write --list-different **/*.ts", | |||
| "watch": "yarn tsc-watch --onSuccess \"yarn bundle\"", | |||
| "lint": "yarn eslint --max-warnings=0 --ext .ts . && yarn prettier --check **/*.ts", | |||
| "lint": "yarn eslint --max-warnings=0 --ext .ts .", | |||
There was a problem hiding this comment.
Suggested change
| "lint": "yarn eslint --max-warnings=0 --ext .ts .", | |
| "lint": "eslint --max-warnings=0 --ext .ts .", |
Honestly I don't like using --ext .ts here. Instead, we can remove this flag and skip lib and build folders using ignorePatterns: ['lib/', 'build/'], in .eslintrc.js.
tjzel
added a commit
that referenced
this pull request
Apr 3, 2023
## Summary Slight naming refactor for functions' names to be more self-explanatory. Direct follow up to #4211. ## Test plan No testing required since it's name change only (maybe check if it compiles). --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary Change custom error throws on undefined objects to generic assert for better clarity. Direct follow up to software-mansion#4210. ## Test plan Nothing to test really. --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary Slight naming refactor for functions' names to be more self-explanatory. Direct follow up to software-mansion#4211. ## Test plan No testing required since it's name change only (maybe check if it compiles). --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change custom error throws on undefined objects to generic assert for better clarity. Direct follow up to #4210.
Test plan
Nothing to test really.