[Plugin] [1/9] Remove passing a 'method holder' object and properly use TypeScript for plugin. #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
commented
Mar 13, 2023
tjzel
commented
Mar 13, 2023
| import { isRelease } from './commonFunctions'; | ||
| import { ReanimatedPluginPass } from './commonInterfaces'; | ||
|
|
||
| function generateInlineStylesWarning(path: NodePath<MemberExpression>) { |
There was a problem hiding this comment.
Renaming memberExpression to path was necessary to avoid conflicts and comply with the rest of plugin's naming policies.
tomekzaw
approved these changes
Mar 29, 2023
tjzel
added a commit
that referenced
this pull request
Apr 3, 2023
## Summary Change custom error throws on undefined objects to generic assert for better clarity. Direct follow up to #4210. ## Test plan Nothing to test really. --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…se TypeScript for plugin. (software-mansion#4210) ## Summary Since we are using TypeScript for plugin now we should get rid of passing the magic `t` object as a function argument and use proper imports instead. Also we no longer import whole `BabelCore` and `BabelTypes` but just the required objects. This is a direct follow up to software-mansion#4209 ## Test plan `Yarn jest`, these changes don't touch plugin's logic.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary Change custom error throws on undefined objects to generic assert for better clarity. Direct follow up to software-mansion#4210. ## Test plan Nothing to test really. --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we are using TypeScript for plugin now we should get rid of passing the magic
tobject as a function argument and use proper imports instead. Also we no longer import wholeBabelCoreandBabelTypesbut just the required objects. This is a direct follow up to #4209Test plan
Yarn jest, these changes don't touch plugin's logic.