[Plugin] [3/9] Rename functions. #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin-amend-imports-for-readability
…l/plugins-move-throws-to-asserts
…in-rename-functions
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
…in-rename-functions
tomekzaw
approved these changes
Apr 3, 2023
tjzel
added a commit
that referenced
this pull request
Apr 3, 2023
## Summary Changing some type checking conditions to make them more general and logical. Correcting some of the typechecking for more TypeScripty fashion. Direct follow-up to #4212. ## Test plan Tsc check on plugin is enough. --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary Slight naming refactor for functions' names to be more self-explanatory. Direct follow up to software-mansion#4211. ## Test plan No testing required since it's name change only (maybe check if it compiles). --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…nsion#4214) ## Summary Changing some type checking conditions to make them more general and logical. Correcting some of the typechecking for more TypeScripty fashion. Direct follow-up to software-mansion#4212. ## Test plan Tsc check on plugin is enough. --------- Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slight naming refactor for functions' names to be more self-explanatory. Direct follow up to #4211.
Test plan
No testing required since it's name change only (maybe check if it compiles).