feat(ivc): impl protogalaxy::calculate_betas_stroke
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosma
reviewed
Oct 30, 2024
| .zip_eq(deltas) | ||
| .map(|(beta, delta)| { | ||
| let alpha_mul_delta = main_gate.mul(region, &cha.alpha, &delta)?; | ||
| main_gate.add(region, beta, &alpha_mul_delta) |
There was a problem hiding this comment.
Here we had: beta + alpha * delta, no other options
abcca31 to
19cc6e5
Compare
Base automatically changed from
361-feat-protogalaxy-verify-circuit-2
to
main
November 4, 2024 11:12
**Motivation** Part of protogalaxy protocol in #361 **Overview** Implemented a separate function to get similar `nifs::protogalaxy` beta_stroke calculations
ef81448 to
cfa85ad
Compare
chaosma
approved these changes
Nov 5, 2024
cyphersnake
added a commit
that referenced
this pull request
Nov 12, 2024
**Motivation** Это попытка ускорить реализацию #378 If we remove the `FoldingScheme` trait, we can be more flexible in customizing Sangria & ProtoGalaxy types. This is important since Sangria uses a cyclic scheme, Cyclefold has a simpler recursion scheme **Overview** Just remove trait and use all methods directly. Structure of methods not changed
cyphersnake
added a commit
that referenced
this pull request
Nov 12, 2024
**Motivation** This is an attempt to speed up the implementation of #378 If we remove the `FoldingScheme` trait, we can be more flexible in customizing Sangria & ProtoGalaxy types. This is important since Sangria uses a cyclic scheme, Cyclefold has a simpler recursion scheme **Overview** Just remove trait and use all methods directly. Structure of methods not changed
cyphersnake
added a commit
that referenced
this pull request
Nov 12, 2024
**Motivation** This is an attempt to speed up the implementation of #378 If we remove the `FoldingScheme` trait, we can be more flexible in customizing Sangria & ProtoGalaxy types. This is important since Sangria uses a cyclic scheme, Cyclefold has a simpler recursion scheme **Overview** Just remove trait and use all methods directly. Structure of methods not changed
cyphersnake
added a commit
that referenced
this pull request
Nov 19, 2024
**Motivation** This is an attempt to speed up the implementation of #378 If we remove the `FoldingScheme` trait, we can be more flexible in customizing Sangria & ProtoGalaxy types. This is important since Sangria uses a cyclic scheme, Cyclefold has a simpler recursion scheme **Overview** Just remove trait and use all methods directly. Structure of methods not changed
cyphersnake
added a commit
that referenced
this pull request
Nov 19, 2024
**Motivation** This is an attempt to speed up the implementation of #378 If we remove the `FoldingScheme` trait, we can be more flexible in customizing Sangria & ProtoGalaxy types. This is important since Sangria uses a cyclic scheme, Cyclefold has a simpler recursion scheme **Overview** Just remove trait and use all methods directly. Structure of methods not changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of protogalaxy protocol in #361
Overview
Implemented a separate function to get similar
nifs::protogalaxybeta_stroke calculations