feat: impl cyclefold::step_folding_circuit blank
#386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4384df6 to
aa82d4b
Compare
fc4ea2b to
9de3a48
Compare
aa82d4b to
61661b0
Compare
9de3a48 to
6d7dfb0
Compare
6d7dfb0 to
699c87a
Compare
**Motivation** In #371 we should use ECC gadget but with tiny-gate for small degree This will allow cyclefold to be used in conjunction with sangria **Overview** WIP
**Motivation** As part of task #371, we will need gadget-ecc, but for optimization purposes, we will need it on a tiny-gate so that we can on-circuit verify it, using the Sangria protocol. So we need to ensure that we can use ecc-gate with more than just the main-gate **Overview** All main-gate methods were put into a separate `trait EccGate`, which was immediately implemented for `MainGate`. Thus, this commit does not bring any functional changes __Extras__: - `fn _add_unsafe` -> `unsafe fn unchecked_add` - `fn _double_unsafe` -> `unsafe fn unchecked_double` This refactor was made to be more in line with the idiom of Rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
First part of #378
Overview
WIP