refactor(nifs): rm trait FoldingScheme
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333a4b8 to
d0e08fa
Compare
chaosma
approved these changes
Nov 15, 2024
**Motivation** This is an attempt to speed up the implementation of #378 If we remove the `FoldingScheme` trait, we can be more flexible in customizing Sangria & ProtoGalaxy types. This is important since Sangria uses a cyclic scheme, Cyclefold has a simpler recursion scheme **Overview** Just remove trait and use all methods directly. Structure of methods not changed
d0e08fa to
a938abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an attempt to speed up the implementation of #378
If we remove the
FoldingSchemetrait, we can be more flexible in customizing Sangria & ProtoGalaxy nifs types.This is important since Sangria uses a cyclic scheme, Cyclefold has a simpler recursion scheme
Overview
Just remove trait and use all methods directly. Structure of methods not changed