Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make profile keys case-insensitive #3344

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Make profile keys case-insensitive #3344

merged 3 commits into from
Jan 9, 2024

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Jan 4, 2024

Motivation and Context

Description

To match the CLI behavior and improve customer experience, make the keys on the profile file case-insensitive.

Testing

  • New credentials integration test

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Jan 4, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh marked this pull request as ready for review January 5, 2024 15:15
@rcoh rcoh requested review from a team as code owners January 5, 2024 15:15
Copy link

github-actions bot commented Jan 5, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@rcoh rcoh added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit 49622b2 Jan 9, 2024
40 of 41 checks passed
@rcoh rcoh deleted the case-insensitive-config branch January 9, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants