Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS credentials file keys should not be case sensitive #1020

Closed
trevorstr opened this issue Dec 19, 2023 · 5 comments
Closed

AWS credentials file keys should not be case sensitive #1020

trevorstr opened this issue Dec 19, 2023 · 5 comments
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@trevorstr
Copy link

Describe the bug

The AWS SDK for Rust requires lowercase keys, such as aws_access_key_id instead of AWS_ACCESS_KEY_ID. This is inconsistent with the AWS CLI, and I'm 90% confident other SDKs don't have this limitation either.

Expected Behavior

AWS credentials file should support case insensitive configuration keys.

Current Behavior

AWS SDK for Rust requires lower-case keys in the AWS credentials file.

Reproduction Steps

[default]
AWS_ACCESS_KEY_ID=asdf
AWS_SECRET_ACCESS_KEY=asdf
REGION=us-west-1

Possible Solution

Make the profile file credentials chain case insensitive.

Additional Information/Context

No response

Version

rust-aws-rekognition v0.1.0 (/workspaces/rust-aws-rekognition)
├── aws-config v1.1.1



### Environment details (OS name and version, etc.)

Linux / GitHub Codespaces

### Logs

_No response_
@trevorstr trevorstr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 19, 2023
@trevorstr trevorstr mentioned this issue Dec 19, 2023
Open
@vemarun
Copy link

vemarun commented Dec 20, 2023

Today same case with me but this thing was highlighted by rust-analyzer.
I am not sure if this bug is in sdk or rust-analyzer enforces it that way.
Field AWS_ACCESS_KEY_ID should have snake_case name, e.g. aws_access_key_id rust-analyzer[non_snake_case](https://doc.rust-lang.org/rustc/?search%3Dnon_snake_case)

This was referenced Jan 5, 2024
Merged
Closed
@jmklix jmklix added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2024
@rcoh
Copy link
Contributor

rcoh commented Jan 5, 2024

This will be fixed in smithy-lang/smithy-rs#3344, thanks for reporting!

github-merge-queue bot pushed a commit to smithy-lang/smithy-rs that referenced this issue Jan 9, 2024
@rcoh
Make profile keys case-insensitive (#3344)
49622b2 
## Motivation and Context
- https://github.com/aws/aws-sdk/issues/574
- awslabs/aws-sdk-rust#1020

## Description
To match the CLI behavior and improve customer experience, make the keys
on the profile file case-insensitive.

## Testing
- New credentials integration test

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@rcoh
Copy link
Contributor

rcoh commented Jan 11, 2024 •
edited
Loading

fixed in the latest version of aws-config

@rcoh rcoh closed this as completed Jan 11, 2024
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@trevorstr
Copy link
Author

@rcoh Nice, thanks

@floralph floralph mentioned this issue Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rcoh @jmklix @vemarun @trevorstr