Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for case insensitive properties in the aws credentials file #5689

Open
debora-ito opened this issue Aug 8, 2023 · 2 comments
Open
Assignees
Labels
cross-sdk feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@debora-ito
Copy link
Member

debora-ito commented Aug 8, 2023

Originally reported in #4164.

Some SDKs (like Java, .NET, Javascript, Ruby) only support lowercase attributes in the aws credentials file, like:

[default]
aws_access_key_id=
aws_secret_access_key=
aws_session_token=

Uppercase properties like AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY are ignored by most SDKs - although it works fine in AWS CLI.

This is a feature request for support of case insensitive credentials file properties , in a consistent manner across all the SDKs.

Community note: please add a 👍 if you are interested in this.

@trevorstr
Copy link

I opened a bug for this today, for the Rust SDK. I wasted hours trying to figure out why the AWS CLI was working perfectly fine, but the Rust SDK wasn't.

awslabs/aws-sdk-rust#1020

github-merge-queue bot referenced this issue in smithy-lang/smithy-rs Jan 9, 2024
## Motivation and Context
- https://github.com/aws/aws-sdk/issues/574
- awslabs/aws-sdk-rust#1020

## Description
To match the CLI behavior and improve customer experience, make the keys
on the profile file case-insensitive.

## Testing
- New credentials integration test

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@debora-ito debora-ito added the p2 This is a standard priority issue label Aug 30, 2024
@debora-ito
Copy link
Member Author

Transferring back to the Java SDK 2.x repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-sdk feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants