Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace endpoint list filter views with django-filters #704

Merged
merged 18 commits into from
Nov 9, 2022
Merged

Replace endpoint list filter views with django-filters #704

merged 18 commits into from
Nov 9, 2022

Conversation

shapiromatron
Copy link
Owner

@shapiromatron shapiromatron commented Oct 6, 2022 •
edited by rabstejnek
Loading

Updated the list views for animal Endpoint, epi Outcome, epimeta MetaResult, and invitro IVEndpoint to use django-filters instead of our own hand rolled solution.

@rabstejnek rabstejnek changed the title begin prefilters Replace endpoint list filter views with django-filters Oct 19, 2022
@rabstejnek rabstejnek marked this pull request as ready for review October 19, 2022 15:40
@rabstejnek
Copy link
Collaborator

@shapiromatron Ready for review!

shapiromatron
shapiromatron commented Nov 7, 2022
View reviewed changes
Copy link
Owner Author

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still checking this out, but I noticed that if I'm unauthenticated, I cannot filter, even on public assessments. The autocomplete fields return 403. This needs to be fixed so that filters work even if you're not logged in.

@shapiromatron
Copy link
Owner Author

shapiromatron commented Nov 8, 2022 •
edited
Loading

Still checking this out, but I noticed that if I'm unauthenticated, I cannot filter, even on public assessments. The autocomplete fields return 403. This needs to be fixed so that filters work even if you're not logged in.

I fixed this by removing the requirement that autocompletes require authentication. We added this with the dal rewrite #667, so this wasn't introduced in this PR, but just observed here.

shapiromatron
shapiromatron commented Nov 8, 2022
View reviewed changes
Copy link
Owner Author

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a number of changes and am really happy with how this turned out! I can assign to you to review my changes, and if so, ok to merge :)

@shapiromatron shapiromatron mentioned this pull request Nov 9, 2022
Merged
shapiromatron
shapiromatron commented Nov 9, 2022
View reviewed changes
Copy link
Owner Author

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rabstejnek rabstejnek merged commit 773e2fa into main Nov 9, 2022
@rabstejnek rabstejnek deleted the prefilters branch November 9, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabstejnek rabstejnek rabstejnek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shapiromatron @rabstejnek