-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
django-selectable -> django-autocomplete-light #667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work. After we complete laying the framework here, we'll probably progressively work through the app, replacing one lookups.py
file at at a time...
…abels as autocomplete choices
@shapiromatron ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to merge this in! Really big and complicated PR, the autocomplete abstractions look very convenient and easy to use. I changed the single file into a package to give it some room to grow, and made a few other minor changes, but the bones of this PR were solid and clearly very well tested and designed.
Excellent job! Goodbye django-selectable, you've served us well (and also jquery UI).
We will have to figure out how to deal with this flaky epiv2 integration test a little further down the road...
Replace django-selectable (no longer supported) with django-autocomplete-light.
In addition: