Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-selectable -> django-autocomplete-light #667

Merged
merged 60 commits into from
Sep 8, 2022
Merged

django-selectable -> django-autocomplete-light #667

merged 60 commits into from
Sep 8, 2022

Conversation

rabstejnek
Copy link
Collaborator

@rabstejnek rabstejnek commented Jul 21, 2022

Replace django-selectable (no longer supported) with django-autocomplete-light.

In addition:

Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work. After we complete laying the framework here, we'll probably progressively work through the app, replacing one lookups.py file at at a time...

@rabstejnek rabstejnek marked this pull request as ready for review July 29, 2022 18:38
@rabstejnek rabstejnek changed the title Replace django-selectable with django-autocomplete-light Added django-autocomplete-light Jul 29, 2022
@rabstejnek rabstejnek changed the title Added django-autocomplete-light Add django-autocomplete-light Jul 29, 2022
@rabstejnek rabstejnek requested a review from shapiromatron July 29, 2022 18:57
@shapiromatron shapiromatron changed the base branch from main to next August 31, 2022 11:59
@rabstejnek
Copy link
Collaborator Author

@shapiromatron ready for review!

@shapiromatron shapiromatron mentioned this pull request Sep 6, 2022
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to merge this in! Really big and complicated PR, the autocomplete abstractions look very convenient and easy to use. I changed the single file into a package to give it some room to grow, and made a few other minor changes, but the bones of this PR were solid and clearly very well tested and designed.

Excellent job! Goodbye django-selectable, you've served us well (and also jquery UI).

We will have to figure out how to deal with this flaky epiv2 integration test a little further down the road...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants