restore dose-unit endpoint values to endpoint list #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # hawc/apps/animal/templates/animal/endpoint_list.html
# Conflicts: # hawc/apps/animal/filterset.py # hawc/apps/animal/templates/animal/endpoint_list.html # hawc/apps/animal/views.py # hawc/apps/epi/filterset.py # hawc/apps/epi/views.py # hawc/apps/epimeta/filterset.py # hawc/apps/epimeta/views.py # hawc/apps/invitro/filterset.py # hawc/apps/invitro/views.py
rabstejnek
approved these changes
Nov 9, 2022
| @@ -104,9 +104,51 @@ def by_dose_regime(self, dose_regime): | |||
| return self.filter(dose_regime=dose_regime) | |||
|
|
|||
|
|
|||
| class EndpointQuerySet(QuerySet): | |||
| def annotate_dose_values(self, dose_units: Optional[DoseUnits] = None) -> QuerySet: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#704 simplified how endpoint list views were generated, but we removed the JS implementation of the views which simplified the data which was available for the view. This PR restores the original view, where dose-unit specific data (NOEL, LOEL, BMD, and BMDL) are presented for each endpoint.
We implement by a custom database query, so we don't need to build the whole JS instance of the object, but instead query for what's needed. The end result is a faster view, though we lose the desirable caching properties of the serialized objects.