Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate annotation(s) for expecting exceptions #3332

Closed
sebastianbergmann opened this issue Oct 10, 2018 · 4 comments
Closed

Deprecate annotation(s) for expecting exceptions #3332

sebastianbergmann opened this issue Oct 10, 2018 · 4 comments
Assignees
@sebastianbergmann
Milestone
PHPUnit 8.0

Comments

@sebastianbergmann
Copy link
Owner

No description provided.

@sebastianbergmann sebastianbergmann added this to the PHPUnit 7.5 milestone Oct 10, 2018
@sebastianbergmann sebastianbergmann self-assigned this Oct 10, 2018
@keradus
Copy link
Contributor

keradus commented Oct 10, 2018

Note for interested folks:
PHP CS Fixer has a rule to automatically apply this change and convert those annotations into methods call: php_unit_no_expectation_annotation

@keradus
Copy link
Contributor

keradus commented Oct 10, 2018

@sebastianbergmann , would it make sense to deprecate those annotations at 7.5 and drop at 8.0 ?
As always, I'm happy to help on that

@sebastianbergmann
Copy link
Owner Author

While I initially wanted to do that, I do not think that the two months between December and February are enough for a deprecation period.

@keradus
Copy link
Contributor

keradus commented Oct 11, 2018

I believe it's fine - one thing is that it's not that short - but other, not everyone will migrate to new MAJOR at beginning of February.

looking at packagist stats ( https://repo-stats.github.io ), fragmentation is big
screenshot from 2018-10-11 13-48-38

for that, I believe it's worth to do it now instead of setting up a deprecation that would live for more than year.

sebastianbergmann added a commit that referenced this issue Oct 11, 2018
@sebastianbergmann
Initial work on ##3332, #3338, and #3341
c584a0d
@DavertMik DavertMik mentioned this issue Oct 16, 2018
Merged
burned42 added a commit to burned42/Codeception that referenced this issue Oct 17, 2018
@burned42
don't use @ExpectedException annotation as it will get deprecated
f8a2b52 
see sebastianbergmann/phpunit#3332
DavertMik pushed a commit to Codeception/Codeception that referenced this issue Oct 18, 2018
@burned42 @DavertMik
Asserts: Add expectThrowable() method (#5213)
9549e30 
* Asserts: add expectThrowable()

With this method you can not only test Exceptions, like with expectException, but also Errors.

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts tests: set up test class in setUp()

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: mention expectThrowable in the documentation

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: add type hint

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: since we marked expectedException as deprecated, use expectThrowable instead

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* fix typos

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: try to make expectThrowable compatible with PHP 5.6 again

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* don't use @ExpectedException annotation as it will get deprecated

see sebastianbergmann/phpunit#3332
@sebastianbergmann sebastianbergmann mentioned this issue Jan 4, 2019
Closed
@ericpoe ericpoe mentioned this issue May 3, 2019
Merged
@peter279k peter279k mentioned this issue Jun 14, 2019
Closed
Naktibalda pushed a commit to Codeception/module-asserts that referenced this issue Sep 16, 2019
@burned42 @DavertMik
Asserts: Add expectThrowable() method (#5213)
11fc397 
* Asserts: add expectThrowable()

With this method you can not only test Exceptions, like with expectException, but also Errors.

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts tests: set up test class in setUp()

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: mention expectThrowable in the documentation

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: add type hint

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: since we marked expectedException as deprecated, use expectThrowable instead

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* fix typos

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: try to make expectThrowable compatible with PHP 5.6 again

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* don't use @ExpectedException annotation as it will get deprecated

see sebastianbergmann/phpunit#3332
@stevegrunwell stevegrunwell mentioned this issue Sep 16, 2019
Merged
Naktibalda pushed a commit to Codeception/module-asserts that referenced this issue Sep 19, 2019
@burned42 @DavertMik
Asserts: Add expectThrowable() method (#5213)
9fbb2bf 
* Asserts: add expectThrowable()

With this method you can not only test Exceptions, like with expectException, but also Errors.

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts tests: set up test class in setUp()

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: mention expectThrowable in the documentation

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: add type hint

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: since we marked expectedException as deprecated, use expectThrowable instead

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* fix typos

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* Asserts: try to make expectThrowable compatible with PHP 5.6 again

Signed-off-by: Bernd Stellwag <burned@zerties.org>

* don't use @ExpectedException annotation as it will get deprecated

see sebastianbergmann/phpunit#3332
This was referenced Oct 25, 2019
Merged
Merged
@DQNEO DQNEO mentioned this issue Jan 17, 2020
Closed
@mszabo-wikia mszabo-wikia mentioned this issue Mar 15, 2020
Merged
@peter279k peter279k mentioned this issue Mar 24, 2020
Closed
@MKodde MKodde mentioned this issue Apr 1, 2020
Merged
1 task
@jeromegamez jeromegamez mentioned this issue Apr 26, 2020
Merged
@oschwald oschwald mentioned this issue May 13, 2020
Merged
@SimonHeimberg SimonHeimberg mentioned this issue May 18, 2020
Merged
franmomu added a commit to franmomu/DoctrineMongoDBBundle that referenced this issue Oct 21, 2020
@franmomu
Replace deprecated PHPUnit code
403ce15 
The annotations expectedException and expectedExceptionMessage
has been replace with the corresponding expecting exceptions, ref:
sebastianbergmann/phpunit#3332

Also a call to TestCase::assertInternalType has been replaced
with TestCase::assertIsInt.
franmomu added a commit to franmomu/DoctrineMongoDBBundle that referenced this issue Nov 28, 2020
@franmomu
Replace deprecated PHPUnit code
b092575 
The annotations expectedException and expectedExceptionMessage
has been replace with the corresponding expecting exceptions, ref:
sebastianbergmann/phpunit#3332

Also a call to TestCase::assertInternalType has been replaced
with TestCase::assertIsInt.
franmomu added a commit to franmomu/DoctrineMongoDBBundle that referenced this issue Nov 30, 2020
@franmomu
Replace deprecated PHPUnit code
ca21f47 
The annotations expectedException and expectedExceptionMessage
has been replace with the corresponding expecting exceptions, ref:
sebastianbergmann/phpunit#3332

Also a call to TestCase::assertInternalType has been replaced
with TestCase::assertIsInt.
franmomu added a commit to franmomu/DoctrineMongoDBBundle that referenced this issue Dec 3, 2020
@franmomu
Replace deprecated PHPUnit code
83d7c47 
The annotations expectedException and expectedExceptionMessage
has been replace with the corresponding expecting exceptions, ref:
sebastianbergmann/phpunit#3332

Also a call to TestCase::assertInternalType has been replaced
with TestCase::assertIsInt.
@HillLiu HillLiu mentioned this issue Apr 3, 2021
Closed
vitormattos added a commit to LibreCodeCoop/php-swagger-test that referenced this issue May 29, 2021
@vitormattos
Make compatible with latest PHPUnit version
6d10a33 
sebastianbergmann/phpunit#3332
ordago added a commit to ordago/sermepa that referenced this issue Jun 14, 2021
@ordago
refactors deprecated phpunit annotations
fc034fe 
sebastianbergmann/phpunit#3332
@Pen-y-Fan Pen-y-Fan mentioned this issue Oct 3, 2021
Closed
pH-7 added a commit to pH7Software/pH7-Social-Dating-CMS that referenced this issue Jan 2, 2022
@pH-7
@expectedException annotation has been deprecated & removed
015a44a 
Ref: sebastianbergmann/phpunit#3332
GoreSakuraba pushed a commit to GoreSakuraba/php-openapi-test that referenced this issue Jul 22, 2022
@vitormattos @GoreSakuraba
Make compatible with latest PHPUnit version
20337a9 
sebastianbergmann/phpunit#3332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
None yet
Projects
None yet
Milestone
PHPUnit 8.0
Development

No branches or pull requests
2 participants
@sebastianbergmann @keradus