Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only compatible with PHP 7.4, bump PHPUnit to allow PHP 8? #41

Closed
Pen-y-Fan opened this issue Oct 3, 2021 · 1 comment · Fixed by #43
Closed

Only compatible with PHP 7.4, bump PHPUnit to allow PHP 8? #41

Pen-y-Fan opened this issue Oct 3, 2021 · 1 comment · Fixed by #43

Comments

@Pen-y-Fan
Copy link
Contributor

I've had some problems with the setup:

  • PHPUnit has a maximum PHP version of 7.4,
  • rubix/ml has a minimum PHP version of 7.4,

composer install can only be run using PHP 7.4, it will not run on PHP 8.

I'm happy to bump PHPUnit to 9.5, which will give PHP 7.4 & PHP 8. I can fix the deprecated annotation(s) for expecting exceptions, is this Ok? Would you be willing to tag with Hacktoberfest?
@programarivm
Copy link
Member

@Pen-y-Fan, welcome to ChesslabLab.

Thank you for joining the community and raising an issue.

That's a good point. I can't wait to see what you come up with!

programarivm added a commit that referenced this issue Oct 4, 2021
@programarivm
Merge pull request #43 from Pen-y-Fan/bump-phpunit
5b42d32 
Bump phpunit (#41)
@programarivm programarivm mentioned this issue Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump phpunit (#41) Pen-y-Fan/chess-server
2 participants
@programarivm @Pen-y-Fan