This repository has been archived by the owner on May 3, 2023. It is now read-only.
Create a new ready session use case #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Packages updated with php 7.2.29 - Security updates - Downgrade some symfony packages from 5.0.* to 4.4.*
- ReadySession encapsulate the response from ReadID backend - Added uuid dependency - Disabled some Doctrine rules from phpcs
- Command to get a new ReadySession from ReadID server - Depends on RequestReadySessionInterface service in infrastructure
- Depends on HttpReadIDClientInterface
- Fixed create ReadySession endpoint - Fixed json body argument - Fixed headers argument
- Disabled SYMFONY_DEPRECATIONS_HELPER - Configured tested services as public - Mocked three available responses
MKodde
reviewed
Apr 1, 2020
There was a problem hiding this comment.
Hi @sgomez
Nice work! It takes some getting used to as you have different coding habits than the team I usually work with. But that makes it a learning experience for me.
See my feedback in the blocks below.
One other thing I noticed and you might want to experiment with is the following. Your commit messages are good, and you keep your commits nice and atomic. To improve the git log readability and overall quality of your commit messages please review https://chris.beams.io/posts/git-commit/. The break of rule 5: 'use the imperative mood' triggered this with me. Other than that your messages look great. Just sharing this, as it once was a great eye-opener for me.
tests/Unit/Infrastructure/Services/HttpReadIDConfigurationTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Infrastructure/Services/HttpRequestReadySessionTest.php
Outdated
Show resolved
Hide resolved
tests/Functional/Application/ReadySession/GetReadySessionQueryHandlerTest.php
Outdated
Show resolved
Hide resolved
MKodde
approved these changes
Apr 2, 2020
tests/Functional/Application/ReadySession/GetReadySessionQueryHandlerTest.php
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Pending: