Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/dev-107.30 → develop #2057

Merged
merged 27 commits into from
Dec 12, 2024
Merged

hotfix/dev-107.30 → develop #2057

merged 27 commits into from
Dec 12, 2024

Conversation

jakobvogel
Copy link
Member

@jakobvogel jakobvogel commented Dec 6, 2024

@jakobvogel jakobvogel added the 🛠️ Maintenance Translations, Code Cleanup, ... label Dec 6, 2024
jakobvogel and others added 17 commits December 6, 2024 11:28
OX-9272

Co-authored-by: Sascha Bieberstein <sabieber@users.noreply.github.com>
…as requested by @sabieber during review.

OX-9272
…as requested by @sabieber during review.

OX-9272
…as requested by @sabieber during review.

OX-9272

Co-authored-by: Sascha Bieberstein <sbi@scireum.de>
…as inspired by a review comment by @sabieber.

OX-9272
…as requested by @sabieber during review,

OX-9272
…as suggested by @sabieber during review.

OX-9272
…as requested by @sabieber during review.

OX-9272
In order to make the chart more easily accessible, a new class is introduced. However, the functionality all resides in the pie chart, as a doughnut chart can degenerate to a pie chart.

The renaming was suggested by @sabieber during review. Writing adapted to BE, as is done in Wikipedia.

OX-9272
…as requested by @sabieber during review.

OX-9272
…as suggested by @sabieber during review.

OX-9272
…as I misunderstood @sabieber's review feedback.

OX-9272
…as implied by a review comment by @sabieber.

OX-9272
@jakobvogel jakobvogel marked this pull request as ready for review December 12, 2024 10:25
@jakobvogel jakobvogel merged commit 4f95315 into develop Dec 12, 2024
3 checks passed
@jakobvogel jakobvogel deleted the hotfix/dev-107.3.0 branch December 12, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Maintenance Translations, Code Cleanup, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant