Solves an issue where importing an XML file causes large portions of the file to be loaded in RAM #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were fitting a custom handler to process events after the loaded node all the time, even if we have no event to call. Fixes: OX-11723
When adding a node handler, we must check if the original handler was set to ignore contents, otherwise, the entire sub-three will be loaded. For example, trying to read the BMEcat version from the root element, we want to read this element alone and not the entire file. Fixes: OX-11723
jakobvogel
approved these changes
Dec 5, 2024
sabieber
approved these changes
Dec 5, 2024
jmuscireum
approved these changes
Dec 5, 2024
fhaScireum
approved these changes
Dec 5, 2024
Fixes: OX-11723
mkeckmkeck
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the introduction of customer-scripting when loading XML files, we add a custom handler to process the events before calling the original handler, but unfortunately did not check if the original node handler was configured to ignore its contents (sub-tree). A use case for this: reading BMEcat's version from the root element, without having to load the entire file.
This change not only correctly cope with this case, but won't create this unnecessary handler if scripting is not active at all.
Additional Notes
Checklist