SVG Charts for PDFs (OX-9272) #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as the library will not be used due to "outdated" graphics. OX-9272
…that can be rendered as SVGs (for later use in PDFs). OX-9272
…to the versions used in OX release 2024.12 OX-9272
sabieber
approved these changes
Dec 5, 2024
idlira
approved these changes
Dec 6, 2024
OX-9272 Co-authored-by: Sascha Bieberstein <sabieber@users.noreply.github.com>
…as requested by @sabieber during review. OX-9272
…as requested by @sabieber during review. OX-9272
OX-9272
…as requested by @sabieber during review. OX-9272 Co-authored-by: Sascha Bieberstein <sbi@scireum.de>
…as inspired by a review comment by @sabieber. OX-9272
…as requested by @sabieber during review, OX-9272
…as suggested by @sabieber during review. OX-9272
…as requested by @sabieber during review. OX-9272
In order to make the chart more easily accessible, a new class is introduced. However, the functionality all resides in the pie chart, as a doughnut chart can degenerate to a pie chart. The renaming was suggested by @sabieber during review. Writing adapted to BE, as is done in Wikipedia. OX-9272
…as requested by @sabieber during review. OX-9272
…as suggested by @sabieber during review. OX-9272
sabieber
approved these changes
Dec 11, 2024
sabieber
approved these changes
Dec 11, 2024
jmuscireum
approved these changes
Dec 12, 2024
idlira
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides a framework for charts that can be rendered (via SVG) into PDFs. Currently, only pie and spider charts are supported.
Screenies
Additional Notes
Checklist