Add symfony 3.0 support #202
Conversation
|
Any idea why the annotations are not loaded in the functional tests? |
|
It seems to be fixed by loading them in the |
|
The tests are completely fixed this time! |
|
Can you take a look @schmittjoh please? |
|
Good job @Ener-Getick :-) |
|
Would be great! :) |
| break; | ||
| } | ||
| $dir = dirname($dir); | ||
| } |
There was a problem hiding this comment.
IMO, this logic is useless. Tests are not meant to be run with the bundle being the root package. Otherwise, you won't have the optional deps
|
I agree with what @stof said. |
|
👍 |
|
very good -) |
|
+1 |
|
👍 |
1 similar comment
|
👍 |
|
👍 |
|
@schmittjoh can we merge this? We're all waiting for it! 🎱 |
|
@Jean85 as a temporary solution you can use my repository (see https://getcomposer.org/doc/05-repositories.md#vcs) with But be aware that I will probably remove it when this PR will be merged. |
|
@schmittjoh Any plans about merging this PR? Would help a lot ;) |
|
Ye, would definitely help, as this is one of the few remaining issues, stopping us from upgrading to 3.0. If there is anything we could do speed up the merge, let us know. |
|
@kYem you can try to ping @schmittjoh on twitter ;-) |
|
👍 Thx |
|
@schmittjoh could we please have this merged? alot of projects await to upgrade to symfony 3.0 |
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
|
@schmittjoh ping :) |
|
Finally merged :-) |
|
Kudos @Ener-Getick & @schmittjoh ! |
|
Woha!!! Great!! |
|
Thank you @Jean85 :-) |
Replaces #198