PHP 7 compatibility #200
Closed
PHP 7 compatibility #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot use 'String' as a class name since this is a reserved keyword in PHP 7. The conflicting class is not used anywhere by the bundle, so it was removed.
|
Fixes #196 |
|
Removing the class is a BC break. Doing a new major version of the bundle just for that is not worth it. |
|
Ok agreed. How would you suggest handling the failing test case? |
|
@thomask this test should be skipped when using php 7.0. |
| @@ -13,7 +13,7 @@ | |||
| ], | |||
| "minimum-stability": "dev", | |||
| "require": { | |||
| "php": "~5.3", | |||
| "php": ">=5.3", | |||
There was a problem hiding this comment.
I prefer using ~5.3|~7.0
|
Closing as this will already be fixed in PR #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot use 'String' as a class name since this is a reserved keyword in PHP 7. The conflicting class is not used anywhere by the bundle, so it was removed.