Add symfony 3.0 support #227

GuilhemN · 2015-12-09T17:48:01Z

This PR adds symfony 3.0 support and uses safer version constraints.

(Tests are failing because of JMSSecurityExtraBundle)

Ma27 · 2015-12-10T06:12:08Z

.travis.yml


-script: phpunit --coverage-clover clover
+script: if [ "$COVERAGE" == "true" ]; then phpunit --coverage-clover=clover; else phpunit; fi


that's why the older builds end up with a parse error: travis-ci/travis-ci#5206

I do not understand what you mean.

obsolete actually. Some time ago travis provided phpunit 5 on all builds which caused a syntax error as phpunit 5 requires php 5.6.

ok thanks I didn't see that error ^^

schmittjoh · 2015-12-22T11:37:15Z

Is this ready, or does it still need changes in the security bundle?

GuilhemN · 2015-12-22T11:39:43Z

Still needs some changes, I didn't have the time to finalize it sorry...

Jean85 · 2015-12-22T11:41:01Z

@Ener-Getick can I lend a hand? My PR on JMSSecurityExtraBundle could fix your problems maybe?

schmittjoh/JMSSecurityExtraBundle#197

hacfi · 2015-12-22T12:00:05Z

Been using this PR/fork for 1.5 weeks and it works like a charm!

GuilhemN · 2015-12-22T13:51:14Z

@schmittjoh it is ready now

MisatoTremor · 2015-12-28T10:30:53Z

@Ener-Getick Could you please also change
JMS\DiExtraBundle\Config\FastDirectoriesResource to implement SelfCheckingResourceInterface instead of ResourceInterface because ResourceInterface::isFresh is removed in 3.0 and has moved to SelfCheckingResourceInterface.
I don't know if there should be additional changes to FastDirectoriesResource, but at least this change will make int compatible with 3.0.

GuilhemN · 2015-12-28T10:47:12Z

Sure I'll change it.

…kingResourceInterface

GuilhemN · 2015-12-28T10:53:03Z

Done @MisatoTremor

Ninir · 2015-12-30T10:32:41Z

Nice work @Ener-Getick, thank you!

whyte624 · 2016-01-11T12:34:17Z

👍

Spea · 2016-01-11T12:51:13Z

👍

GuilhemN · 2016-01-11T20:02:49Z

Thank you @Ninir, I'm just waiting for schmittjoh/JMSSecurityExtraBundle#202 to be merged and then I'll update this PR.

bassrock · 2016-01-12T00:39:40Z

👍

khasinski · 2016-01-12T00:49:03Z

👍

e-doceo · 2016-01-12T18:56:41Z

+1

lenar · 2016-01-17T17:02:47Z

👍

GuilhemN · 2016-01-19T19:39:44Z

For those who can't upgrade to symfony 3.0 because of this bundle, you can use temporary my own repository thanks to composer https://getcomposer.org/doc/05-repositories.md#vcs.

Just be aware that I will probably remove it when this PR will be merged.

hacfi · 2016-01-20T09:44:06Z

Been using @Ener-Getick’s branch for a while now and it’s been working flawlessly.

For the lazy ones..you can copy & paste this:

{
    "repositories": [
        {
            "type": "git",
            "url": "git@github.com:Ener-Getick/JMSDiExtraBundle.git"
        }
    ],
    "require": {
        "jms/di-extra-bundle": "dev-master"
    }
}

AntoineLemaire · 2016-01-22T21:17:20Z

👍

dbu · 2016-01-25T13:53:53Z

@schmittjoh is there something preventing you from merging this and tagging another release?

Ma27 · 2016-01-26T06:05:04Z

the JMSSecurityExtraBundle doesn't have a stable release yet, but you can use the fork of @Ener-Getick which should be pretty stable.

Am 25.01.2016 um 14:53 schrieb David Buchmann notifications@github.com:

@schmittjoh is there something preventing you from merging this and tagging another release?

—
Reply to this email directly or view it on GitHub.

Add symfony 3.0 support

hacfi · 2016-02-03T15:45:43Z

👏

tobias-93 · 2016-02-03T16:06:33Z

@Ener-Getick could you tag a release?

GuilhemN · 2016-02-03T16:14:14Z

@tobias-93 there will be a beta phase before that I tag a stable release (see #224 (comment))

tobias-93 · 2016-02-03T16:15:20Z

Oh yeah, I missed that comment. Thanks!

maxpowel · 2016-02-08T09:06:08Z

Hi, Im getting this error:
Fatal error: Class 'Symfony\Component\DependencyInjection\ContainerAware' not found in /Users/maxpowel/roams/webapi/webapi/vendor/doctrine/doctrine-bundle/Controller/ProfilerController.php on line 28

Call Stack:
0.0004 231672 1. {main}() /Users/maxpowel/roams/webapi/webapi/bin/console:0
0.1386 1987504 2. Symfony\Component\Console\Application->run() /Users/maxpowel/roams/webapi/webapi/bin/console:29
0.1450 2226168 3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:117
0.1450 2226392 4. Symfony\Component\HttpKernel\Kernel->boot() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:68
0.7112 2627480 5. Symfony\Component\HttpKernel\Kernel->initializeContainer() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:117
8.2818 29116528 6. Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:489
9.8735 32111192 7. JMS\DiExtraBundle\HttpKernel\ControllerInjectorsWarmer->warmUp() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/CacheWarmer/CacheWarmerAggregate.php:48
9.8735 32111464 8. JMS\DiExtraBundle\HttpKernel\ControllerInjectorsWarmer->findControllerClasses() /Users/maxpowel/roams/webapi/webapi/vendor/jms/di-extra-bundle/HttpKernel/ControllerInjectorsWarmer.php:35
9.9531 32264296 9. require_once('/Users/maxpowel/roams/webapi/webapi/vendor/doctrine/doctrine-bundle/Controller/ProfilerController.php') /Users/maxpowel/roams/webapi/webapi/vendor/jms/di-extra-bundle/HttpKernel/ControllerInjectorsWarmer.php:60

PHP 2. Symfony\Component\Console\Application->run() /Users/maxpowel/roams/webapi/webapi/bin/console:29
PHP 3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Component/Console/Application.php:117
PHP 4. Symfony\Component\HttpKernel\Kernel->boot() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Console/Application.php:68
PHP 5. Symfony\Component\HttpKernel\Kernel->initializeContainer() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:117
PHP 6. Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:489
PHP 7. JMS\DiExtraBundle\HttpKernel\ControllerInjectorsWarmer->warmUp() /Users/maxpowel/roams/webapi/webapi/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/CacheWarmer/CacheWarmerAggregate.php:48
PHP 8. JMS\DiExtraBundle\HttpKernel\ControllerInjectorsWarmer->findControllerClasses() /Users/maxpowel/roams/webapi/webapi/vendor/jms/di-extra-bundle/HttpKernel/ControllerInjectorsWarmer.php:35
PHP 9. require_once() /Users/maxpowel/roams/webapi/webapi/vendor/jms/di-extra-bundle/HttpKernel/ControllerInjectorsWarmer.php:60

Symfony version 3.0.2 from scratch

francoispluchino · 2016-02-08T09:12:27Z

@maxpowel Use the 1.6.x-dev version (the next 1.6.2 version?) of DoctrineBundle. It's fixed only in dev branch for the moment, not in the 1.6.1 version.

GuilhemN · 2016-02-08T13:23:56Z

@maxpowel doctrine-bundle 1.6.2 is released so just run composer update ;-)

Ma27 reviewed Dec 10, 2015
View reviewed changes

GuilhemN mentioned this pull request Dec 22, 2015

Support bump to Symfony 2.6; support for PHP7 schmittjoh/JMSSecurityExtraBundle#197

Closed

Add symfony 3.0 support

e085968

ResourceInterface::isFresh() has been deprecated in favor of SelfChec…

e4975a7

…kingResourceInterface

Ma27 mentioned this pull request Jan 10, 2016

[WIP] symfony 3.0 migration #225

Closed

francoispluchino mentioned this pull request Feb 3, 2016

Make it compatible with Symfony 3.0 schmittjoh/JMSSecurityExtraBundle#194

Closed

Fix the tests

529e22a

GuilhemN added a commit that referenced this pull request Feb 3, 2016

Merge pull request #227 from Ener-Getick/master

c0977b3

Add symfony 3.0 support

GuilhemN merged commit c0977b3 into schmittjoh:master Feb 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add symfony 3.0 support #227

Add symfony 3.0 support #227

GuilhemN commented Dec 9, 2015

Ma27 Dec 10, 2015

GuilhemN Dec 22, 2015

Ma27 Dec 22, 2015

GuilhemN Dec 22, 2015

schmittjoh commented Dec 22, 2015

GuilhemN commented Dec 22, 2015

Jean85 commented Dec 22, 2015

hacfi commented Dec 22, 2015

GuilhemN commented Dec 22, 2015

MisatoTremor commented Dec 28, 2015

GuilhemN commented Dec 28, 2015

GuilhemN commented Dec 28, 2015

Ninir commented Dec 30, 2015

whyte624 commented Jan 11, 2016

Spea commented Jan 11, 2016

GuilhemN commented Jan 11, 2016

bassrock commented Jan 12, 2016

khasinski commented Jan 12, 2016

e-doceo commented Jan 12, 2016

lenar commented Jan 17, 2016

GuilhemN commented Jan 19, 2016

hacfi commented Jan 20, 2016

AntoineLemaire commented Jan 22, 2016

dbu commented Jan 25, 2016

Ma27 commented Jan 26, 2016 •

edited

Loading

hacfi commented Feb 3, 2016

tobias-93 commented Feb 3, 2016

GuilhemN commented Feb 3, 2016

tobias-93 commented Feb 3, 2016

maxpowel commented Feb 8, 2016

francoispluchino commented Feb 8, 2016

GuilhemN commented Feb 8, 2016


		script: phpunit --coverage-clover clover
		script: if [ "$COVERAGE" == "true" ]; then phpunit --coverage-clover=clover; else phpunit; fi

Add symfony 3.0 support #227

Add symfony 3.0 support #227

Conversation

GuilhemN commented Dec 9, 2015

Ma27 Dec 10, 2015

Choose a reason for hiding this comment

GuilhemN Dec 22, 2015

Choose a reason for hiding this comment

Ma27 Dec 22, 2015

Choose a reason for hiding this comment

GuilhemN Dec 22, 2015

Choose a reason for hiding this comment

schmittjoh commented Dec 22, 2015

GuilhemN commented Dec 22, 2015

Jean85 commented Dec 22, 2015

hacfi commented Dec 22, 2015

GuilhemN commented Dec 22, 2015

MisatoTremor commented Dec 28, 2015

GuilhemN commented Dec 28, 2015

GuilhemN commented Dec 28, 2015

Ninir commented Dec 30, 2015

whyte624 commented Jan 11, 2016

Spea commented Jan 11, 2016

GuilhemN commented Jan 11, 2016

bassrock commented Jan 12, 2016

khasinski commented Jan 12, 2016

e-doceo commented Jan 12, 2016

lenar commented Jan 17, 2016

GuilhemN commented Jan 19, 2016

hacfi commented Jan 20, 2016

AntoineLemaire commented Jan 22, 2016

dbu commented Jan 25, 2016

Ma27 commented Jan 26, 2016 • edited Loading

hacfi commented Feb 3, 2016

tobias-93 commented Feb 3, 2016

GuilhemN commented Feb 3, 2016

tobias-93 commented Feb 3, 2016

maxpowel commented Feb 8, 2016

francoispluchino commented Feb 8, 2016

GuilhemN commented Feb 8, 2016

Ma27 commented Jan 26, 2016 •

edited

Loading