Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sepolia and wc2 #47

Merged
merged 2 commits into from
Aug 7, 2023
Merged

fix: sepolia and wc2 #47

merged 2 commits into from
Aug 7, 2023

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Aug 7, 2023

fixes sepolia network error #37

copied scaffold-eth/scaffold-eth-2#381

@rin-st rin-st linked an issue Aug 7, 2023 that may be closed by this pull request
Challenge 2 - Front end error after setting sepolia as targetNetwork #37
Closed
@technophile-04
Copy link
Collaborator

Tysm @rin-st 🙌,

Regarding the CORS mentioned in #37 it goes away by this PR because we now actually use our own alchemy RPC provider instead of https://rpc.sepolia.org

Actually https://rpc.sepolia.org has some problem with CORS I tried removing alchemyProvider from wagmiConnectors in SE-2 main and it gives CORS error there too

So incase our alchmey RPC breaks and it fallbacks to sepolia public RPC its already broken too, this is present in SE-2 main too

Nothing we can do I think, I will create an issue on wagmi later but I found this discussion wevm/wagmi#2802 (comment)

Nevertheless everything works great as we are using our own alchemy RPC starting this PR 🙌

@technophile-04 technophile-04 merged commit 59cf596 into base-challenge-template Aug 7, 2023
@technophile-04 technophile-04 deleted the fix/sepolia-network branch August 7, 2023 10:04
This was referenced Aug 7, 2023
Merged
Merged
Closed
rin-st added a commit that referenced this pull request Oct 4, 2023
@rin-st @Pabl0cks
@carletex @technophile-04 @ZakGriffith @pankaj512
Challenge 2 backmerge v2 (#100)
5f47af1 
* fix: install duplicate (#24)

* Homogenize Checkpoint titles and Checkpoint 0 extra info (#32)

* Ignore typescript/eslint errors on build (#39)

* fix: sepolia and wc2 (#47)

* fix: theme toggle styles (#46)

* migration to wagmi V1, Viem and daisyUI v3 (#73)

* remove vercel:yolo from root pacakge.json (#77)

* Update useScaffoldContractWrite.ts - Error message typos

* fix 0 price on sepolia network (#85)

* fix: side quest heading (#87)

* Pre-app-router se-2 backmerge (#96)

* fix: remove vercel:yolo

* fix: delete mock test file

* remove use of custom light blue color for copy icon (#104)

* Delete light blue color on txhash copy icons

* Increase placeholder readability in dark mode

---------

Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com>
Co-authored-by: tokodev <pablo@asdloop.com>
rin-st added a commit that referenced this pull request Oct 11, 2023
@rin-st @Pabl0cks
@carletex @technophile-04 @ZakGriffith @pankaj512
feat: backmerge challenge 4 (#102)
0e3c5e8 
* Update README to add a Guide to create New Challenges (#9)

* Update base template README with guide and hints to create new challenges

* README tweaks and add TODO questions

* Remove initial hints (will move it main)

---------

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>

* Install section fromn Challenge 0

* fix: install duplicate (#24)

* Homogenize Checkpoint titles and Checkpoint 0 extra info (#32)

* Ignore typescript/eslint errors on build (#39)

* fix: sepolia and wc2 (#47)

* fix: theme toggle styles (#46)

* migration to wagmi V1, Viem and daisyUI v3 (#73)

* remove vercel:yolo from root pacakge.json (#77)

* Update useScaffoldContractWrite.ts - Error message typos

* fix 0 price on sepolia network (#85)

* fix: side quest heading (#87)

* Pre-app-router se-2 backmerge (#96)

* fix: remove vercel:yolo

* feat: backmerge challenge 4

* fix: yarn lock

* remove use of custom light blue color for copy icon (#104)

* fix: remove mock test file

* Delete light blue color on txhash copy icons

* Increase placeholder readability in dark mode

---------

Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com>
Co-authored-by: tokodev <pablo@asdloop.com>
rin-st added a commit that referenced this pull request Oct 15, 2023
@rin-st @carletex
@technophile-04 @ZakGriffith @pankaj512 @Pabl0cks
Challenge 5 backmerge v2 (#103)
dbc2325 
* Ignore typescript/eslint errors on build (#39)

* fix: sepolia and wc2 (#47)

* fix: theme toggle styles (#46)

* migration to wagmi V1, Viem and daisyUI v3 (#73)

* remove vercel:yolo from root pacakge.json (#77)

* Update useScaffoldContractWrite.ts - Error message typos

* fix 0 price on sepolia network (#85)

* fix: side quest heading (#87)

* Pre-app-router se-2 backmerge (#96)

* fix: remove vercel:yolo

* fix: new interval api

* remove use of custom light blue color for copy icon (#104)

* Delete light blue color on txhash copy icons

* Increase placeholder readability in dark mode

* fix: infinite useEffect

* fix: two rubes received bug

* fix: last event emitting bug

* fix: double setChannels bug 🤯

* Comment Checkpoint 5 code

---------

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com>
Co-authored-by: tokodev <pablo@asdloop.com>
rin-st added a commit that referenced this pull request Apr 12, 2024
@rin-st @Pabl0cks
@carletex @technophile-04 @ZakGriffith @pankaj512
Ch4 backmerge 21/03/24 (#164)
da4e009 
* Update README to add a Guide to create New Challenges (#9)

* Update base template README with guide and hints to create new challenges

* README tweaks and add TODO questions

* Remove initial hints (will move it main)

---------

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>

* Install section fromn Challenge 0

* fix: install duplicate (#24)

* Homogenize Checkpoint titles and Checkpoint 0 extra info (#32)

* Ignore typescript/eslint errors on build (#39)

* fix: sepolia and wc2 (#47)

* fix: theme toggle styles (#46)

* migration to wagmi V1, Viem and daisyUI v3 (#73)

* remove vercel:yolo from root pacakge.json (#77)

* Update useScaffoldContractWrite.ts - Error message typos

* fix 0 price on sepolia network (#85)

* fix: side quest heading (#87)

* Pre-app-router se-2 backmerge (#96)

* fix: remove vercel:yolo

* remove use of custom light blue color for copy icon (#104)

* Delete light blue color on txhash copy icons

* Increase placeholder readability in dark mode

* Base challenge next 14 migration (#126)

* fix: return space-grotesk font (#129)

* feat: migrate next-theme (#132)

* fix: remove redundant logs

* feat: challenge test example (#156)

* feat: backmerge 21/03/2024 (#158)

* fix: remove ChallengeN test file

* feat: fn try catch wrapper

* feat: wrap write functions

* fix: update wrapInTryCatch

* feat: update wrapped functions

---------

Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com>
Co-authored-by: tokodev <pablo@asdloop.com>
rin-st added a commit that referenced this pull request Apr 12, 2024
@rin-st @carletex
@technophile-04 @ZakGriffith @pankaj512 @Pabl0cks
Ch5 backmerge 21/03/24 (#165)
9bbad3a 
* Ignore typescript/eslint errors on build (#39)

* fix: sepolia and wc2 (#47)

* fix: theme toggle styles (#46)

* migration to wagmi V1, Viem and daisyUI v3 (#73)

* remove vercel:yolo from root pacakge.json (#77)

* Update useScaffoldContractWrite.ts - Error message typos

* fix 0 price on sepolia network (#85)

* fix: side quest heading (#87)

* Pre-app-router se-2 backmerge (#96)

* fix: remove vercel:yolo

* remove use of custom light blue color for copy icon (#104)

* Delete light blue color on txhash copy icons

* Increase placeholder readability in dark mode

* Base challenge next 14 migration (#126)

* fix: return space-grotesk font (#129)

* feat: migrate next-theme (#132)

* fix: remove redundant logs

* feat: challenge test example (#156)

* feat: backmerge 21/03/2024 (#158)

* fix: remove ChallengeN test file

* feat: fn try catch wrapper

* fix: update wrapInTryCatch

* fix: wrap write functions

---------

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com>
Co-authored-by: tokodev <pablo@asdloop.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carletex carletex Awaiting requested review from carletex

@technophile-04 technophile-04 Awaiting requested review from technophile-04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Challenge 2 - Front end error after setting sepolia as targetNetwork
2 participants
@rin-st @technophile-04