don't use custom light blue color for copy icon #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thanks! |
rin-st
approved these changes
Oct 3, 2023
Pabl0cks
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Awesome job @pankaj512!! This dark mode icon color was catching my eye during my last tests and just realized you fixed it! ♥
@rin-st Do you think it could be interesting to merge this and backmerge to all the active se-2-challenges PRs so it's fixed on the next merge of each Challenge?
Or it's easier to just change that couple of lines on each PR? I'm still a bit git-noob with merges/backmerges
|
Thanks @pankaj512 for this !!
Yeah I think we can do it 🙌 switch PR branch and run will try to backmerge this in all PR 🙌 |
rin-st
added a commit
that referenced
this pull request
Oct 4, 2023
* fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: lock nextjs * fix: header lg -> xl * fix: remove vercel:yolo * fix: delete mock test file * remove use of custom light blue color for copy icon (#104) * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode --------- Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
rin-st
added a commit
that referenced
this pull request
Oct 4, 2023
* fix: install duplicate (#24) * Homogenize Checkpoint titles and Checkpoint 0 extra info (#32) * Ignore typescript/eslint errors on build (#39) * fix: sepolia and wc2 (#47) * fix: theme toggle styles (#46) * migration to wagmi V1, Viem and daisyUI v3 (#73) * remove vercel:yolo from root pacakge.json (#77) * Update useScaffoldContractWrite.ts - Error message typos * fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: remove vercel:yolo * fix: delete mock test file * remove use of custom light blue color for copy icon (#104) * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode --------- Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Zak G <zakgriffith@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
rin-st
added a commit
that referenced
this pull request
Oct 11, 2023
* Update README to add a Guide to create New Challenges (#9) * Update base template README with guide and hints to create new challenges * README tweaks and add TODO questions * Remove initial hints (will move it main) --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Install section fromn Challenge 0 * fix: install duplicate (#24) * Homogenize Checkpoint titles and Checkpoint 0 extra info (#32) * Ignore typescript/eslint errors on build (#39) * fix: sepolia and wc2 (#47) * fix: theme toggle styles (#46) * migration to wagmi V1, Viem and daisyUI v3 (#73) * remove vercel:yolo from root pacakge.json (#77) * Update useScaffoldContractWrite.ts - Error message typos * fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: remove vercel:yolo * feat: backmerge challenge 4 * fix: yarn lock * remove use of custom light blue color for copy icon (#104) * fix: remove mock test file * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode --------- Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Zak G <zakgriffith@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
rin-st
added a commit
that referenced
this pull request
Oct 15, 2023
* Ignore typescript/eslint errors on build (#39) * fix: sepolia and wc2 (#47) * fix: theme toggle styles (#46) * migration to wagmi V1, Viem and daisyUI v3 (#73) * remove vercel:yolo from root pacakge.json (#77) * Update useScaffoldContractWrite.ts - Error message typos * fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: remove vercel:yolo * fix: new interval api * remove use of custom light blue color for copy icon (#104) * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode * fix: infinite useEffect * fix: two rubes received bug * fix: last event emitting bug * fix: double setChannels bug 🤯 * Comment Checkpoint 5 code --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Zak G <zakgriffith@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
rin-st
added a commit
that referenced
this pull request
Oct 23, 2023
* fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: remove vercel:yolo * feat: backmerge challenge 3 * remove use of custom light blue color for copy icon (#104) * fix: remove mock test file * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode * fix: timing * update retryCount to 0 * fix: move mining interval to hardhat * increase winning numbers from [0..2] -> [0..5] * fix: update readme and tests for 2 -> 5 --------- Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
rin-st
added a commit
that referenced
this pull request
Apr 12, 2024
* Update README to add a Guide to create New Challenges (#9) * Update base template README with guide and hints to create new challenges * README tweaks and add TODO questions * Remove initial hints (will move it main) --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Install section fromn Challenge 0 * fix: install duplicate (#24) * Homogenize Checkpoint titles and Checkpoint 0 extra info (#32) * Ignore typescript/eslint errors on build (#39) * fix: sepolia and wc2 (#47) * fix: theme toggle styles (#46) * migration to wagmi V1, Viem and daisyUI v3 (#73) * remove vercel:yolo from root pacakge.json (#77) * Update useScaffoldContractWrite.ts - Error message typos * fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: remove vercel:yolo * remove use of custom light blue color for copy icon (#104) * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode * Base challenge next 14 migration (#126) * fix: return space-grotesk font (#129) * feat: migrate next-theme (#132) * fix: remove redundant logs * feat: challenge test example (#156) * feat: backmerge 21/03/2024 (#158) * fix: remove ChallengeN test file * feat: fn try catch wrapper * feat: wrap write functions * fix: update wrapInTryCatch * feat: update wrapped functions --------- Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Zak G <zakgriffith@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
rin-st
added a commit
that referenced
this pull request
Apr 12, 2024
* Ignore typescript/eslint errors on build (#39) * fix: sepolia and wc2 (#47) * fix: theme toggle styles (#46) * migration to wagmi V1, Viem and daisyUI v3 (#73) * remove vercel:yolo from root pacakge.json (#77) * Update useScaffoldContractWrite.ts - Error message typos * fix 0 price on sepolia network (#85) * fix: side quest heading (#87) * Pre-app-router se-2 backmerge (#96) * fix: remove vercel:yolo * remove use of custom light blue color for copy icon (#104) * Delete light blue color on txhash copy icons * Increase placeholder readability in dark mode * Base challenge next 14 migration (#126) * fix: return space-grotesk font (#129) * feat: migrate next-theme (#132) * fix: remove redundant logs * feat: challenge test example (#156) * feat: backmerge 21/03/2024 (#158) * fix: remove ChallengeN test file * feat: fn try catch wrapper * fix: update wrapInTryCatch * fix: wrap write functions --------- Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com> Co-authored-by: Zak G <zakgriffith@gmail.com> Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com> Co-authored-by: tokodev <pablo@asdloop.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently copy icon of address component uses custom light blue color but this cause issue when some custom background is used. The issue is icon not clearly visible against some background.
What
Change copy icon of address component to not use custom icon color but keep it default so that it auto adjust against background.
How
Remove custom tailwind css text property.
Test method - add a new address component in debug tab under contact variable so see different against 3 different background.
What to Notice - 3rd address copy button in dark mode before and after
Before Light
After Light
Before Dark
After Dark