Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base challenge next 14 migration #126

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Base challenge next 14 migration #126

merged 5 commits into from
Jan 31, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Jan 26, 2024 •
edited
Loading

Base challenge template migration to next 14/other changes after last migration. Good luck reading it :D (probably testing is enough for most of the things, I mostly copied se-2 code)

In addition all se-2 changes, changed colors a bit, see last commits. For example I disabled hover for top right buttons since hover color is almost the same as background in dark mode.

Next steps:

@rin-st rin-st self-assigned this Jan 26, 2024
Pabl0cks
Pabl0cks approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @rin-st !!

Been testing it and is looking great to me 🙌 To test it I tried to add the Challenge 0 features and everything seems to be working fine!

In addition all se-2 changes, changed colors a bit, see last commits. For example I disabled hover for top right buttons since hover color is almost the same as background in dark mode.

Right now the hover effect is very hard to notice. We could try something like this, or any similar approach that can be noticed in both dark and light mode: hover:bg-black hover:bg-opacity-20
If we can think of a more elegant way to reach it, would be great! 🙃

@rin-st
Copy link
Member Author

rin-st commented Jan 30, 2024 •
edited
Loading

Right now the hover effect is very hard to notice. We could try something like this, or any similar approach that can be noticed in both dark and light mode: hover:bg-black hover:bg-opacity-20
If we can think of a more elegant way to reach it, would be great!

Thanks for review! Changed it only for dark mode, since for light mode black/20 is not looking good

technophile-04
technophile-04 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm Rinat, tested and working great !!

I think maybe we should backmerge this into other challenges I think that should be a bit easy hopefully since they are forked from this branch 🙌

@technophile-04 technophile-04 merged commit c271ee3 into base-challenge-template Jan 31, 2024
@technophile-04 technophile-04 deleted the base-challenge-next-14-migration branch January 31, 2024 17:05
@rin-st
Copy link
Member Author

rin-st commented Jan 31, 2024

I think maybe we should backmerge this into other challenges I think that should be a bit easy hopefully since they are forked from this branch 🙌

Yes, you right. When I wrote first message I thought wagmi migration is fast and it's better to backmerge one time instead of two. But it's not. I'll do backmerges, thanks!

@rin-st rin-st mentioned this pull request Jan 31, 2024
Merged
rin-st added a commit that referenced this pull request Apr 12, 2024
@rin-st @Pabl0cks
@carletex @technophile-04 @ZakGriffith @pankaj512
Ch4 backmerge 21/03/24 (#164)
da4e009 
* Update README to add a Guide to create New Challenges (#9)

* Update base template README with guide and hints to create new challenges

* README tweaks and add TODO questions

* Remove initial hints (will move it main)

---------

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>

* Install section fromn Challenge 0

* fix: install duplicate (#24)

* Homogenize Checkpoint titles and Checkpoint 0 extra info (#32)

* Ignore typescript/eslint errors on build (#39)

* fix: sepolia and wc2 (#47)

* fix: theme toggle styles (#46)

* migration to wagmi V1, Viem and daisyUI v3 (#73)

* remove vercel:yolo from root pacakge.json (#77)

* Update useScaffoldContractWrite.ts - Error message typos

* fix 0 price on sepolia network (#85)

* fix: side quest heading (#87)

* Pre-app-router se-2 backmerge (#96)

* fix: remove vercel:yolo

* remove use of custom light blue color for copy icon (#104)

* Delete light blue color on txhash copy icons

* Increase placeholder readability in dark mode

* Base challenge next 14 migration (#126)

* fix: return space-grotesk font (#129)

* feat: migrate next-theme (#132)

* fix: remove redundant logs

* feat: challenge test example (#156)

* feat: backmerge 21/03/2024 (#158)

* fix: remove ChallengeN test file

* feat: fn try catch wrapper

* feat: wrap write functions

* fix: update wrapInTryCatch

* feat: update wrapped functions

---------

Co-authored-by: Pablo Alayeto <55535804+Pabl0cks@users.noreply.github.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com>
Co-authored-by: tokodev <pablo@asdloop.com>
rin-st added a commit that referenced this pull request Apr 12, 2024
@rin-st @carletex
@technophile-04 @ZakGriffith @pankaj512 @Pabl0cks
Ch5 backmerge 21/03/24 (#165)
9bbad3a 
* Ignore typescript/eslint errors on build (#39)

* fix: sepolia and wc2 (#47)

* fix: theme toggle styles (#46)

* migration to wagmi V1, Viem and daisyUI v3 (#73)

* remove vercel:yolo from root pacakge.json (#77)

* Update useScaffoldContractWrite.ts - Error message typos

* fix 0 price on sepolia network (#85)

* fix: side quest heading (#87)

* Pre-app-router se-2 backmerge (#96)

* fix: remove vercel:yolo

* remove use of custom light blue color for copy icon (#104)

* Delete light blue color on txhash copy icons

* Increase placeholder readability in dark mode

* Base challenge next 14 migration (#126)

* fix: return space-grotesk font (#129)

* feat: migrate next-theme (#132)

* fix: remove redundant logs

* feat: challenge test example (#156)

* feat: backmerge 21/03/2024 (#158)

* fix: remove ChallengeN test file

* feat: fn try catch wrapper

* fix: update wrapInTryCatch

* fix: wrap write functions

---------

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Co-authored-by: Shiv Bhonde | shivbhonde.eth <shivbhonde04@gmail.com>
Co-authored-by: Zak G <zakgriffith@gmail.com>
Co-authored-by: Pankaj Kumar <pkmahan786@gmail.com>
Co-authored-by: tokodev <pablo@asdloop.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technophile-04 technophile-04 technophile-04 approved these changes

@Pabl0cks Pabl0cks Pabl0cks approved these changes

@carletex carletex Awaiting requested review from carletex

Assignees

@rin-st rin-st

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rin-st @Pabl0cks @technophile-04