Add data-sort attributes to dataTables rows to support date sort
#2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a `data-sort` with ISO 8601 datetimes allows dataTables to sort independent of the visible row values. We continue to use javascript to generate the human-readable time for the reasons given in #1416 (support for page caching). We sort to `#iso8601(5)` (i.e. to 5 decimal places). This still allows a mismatch between displayed times and correctly sorted times (off by one second), apparently due to rounding behavior in the javascript sort dates. The actual dates sort correctly, so display dates sort themselves out (ha!) as a notification ages past one minute. Fixes #1653.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
data-sortwith ISO 8601 datetimes allows dataTables to sortindependent of the visible row values. We continue to use javascript to generate
the human-readable time for the reasons given in #1416 (support for page
caching).
We sort to
#iso8601(5)(i.e. to 5 decimal places). This still allows amismatch between displayed times and correctly sorted times (off by one second),
apparently due to rounding behavior in the javascript generated dates. The actual
dates sort correctly, so display dates sort themselves out (ha!) as a
notification ages past one minute.
Fixes #1653.
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers